* [U-Boot] [PATCH] boards: remove the no longer used CONFIG_EHCI_DCACHE
@ 2012-10-22 20:35 Jeroen Hofstee
2012-10-22 20:40 ` Marek Vasut
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: Jeroen Hofstee @ 2012-10-22 20:35 UTC (permalink / raw)
To: u-boot
CONFIG_EHCI_DCACHE was removed by commit b8adb12
"USB: Drop cache flush bloat in EHCI-HCD". Remove the defines from
the boards configs as well.
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
cc: Marek Vasut <marex@denx.de>
cc: Stefan Roese <sr@denx.de>
cc: Tom Rini <trini@ti.com>
cc: Wolfgang Denk <wd@denx.de>
cc: Thierry Reding <thierry.reding@avionic-design.de>
cc: Tom Warren <twarren@nvidia.com>
cc: Stephen Warren <swarren@nvidia.com>
cc: Stefano Babic <sbabic@denx.de>
---
include/configs/lwmon5.h | 1 -
include/configs/mcx.h | 1 -
include/configs/omap3_beagle.h | 1 -
include/configs/sequoia.h | 3 ---
include/configs/tam3517-common.h | 2 --
include/configs/tegra20-common.h | 1 -
include/configs/vct.h | 1 -
7 files changed, 10 deletions(-)
diff --git a/include/configs/lwmon5.h b/include/configs/lwmon5.h
index 2d33ebc..2ebcd16 100644
--- a/include/configs/lwmon5.h
+++ b/include/configs/lwmon5.h
@@ -401,7 +401,6 @@
#define CONFIG_USB_EHCI /* Enable EHCI USB support */
#define CONFIG_USB_EHCI_PPC4XX /* on PPC4xx platform */
#define CONFIG_SYS_PPC4XX_USB_ADDR 0xe0000300
-#define CONFIG_EHCI_DCACHE /* with dcache handling support */
#define CONFIG_EHCI_MMIO_BIG_ENDIAN
#define CONFIG_EHCI_DESC_BIG_ENDIAN
#define CONFIG_EHCI_HCD_INIT_AFTER_RESET /* re-init HCD after CMD_RESET */
diff --git a/include/configs/mcx.h b/include/configs/mcx.h
index 359522a..6251ab7 100644
--- a/include/configs/mcx.h
+++ b/include/configs/mcx.h
@@ -114,7 +114,6 @@
#define CONFIG_USB_EHCI_OMAP
#define CONFIG_USB_ULPI
#define CONFIG_USB_ULPI_VIEWPORT_OMAP
-/*#define CONFIG_EHCI_DCACHE*/ /* leave it disabled for now */
#define CONFIG_OMAP_EHCI_PHY1_RESET_GPIO 154
#define CONFIG_OMAP_EHCI_PHY2_RESET_GPIO 152
#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3
diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
index f79f996..9d435ca 100644
--- a/include/configs/omap3_beagle.h
+++ b/include/configs/omap3_beagle.h
@@ -131,7 +131,6 @@
#define CONFIG_USB_EHCI
#define CONFIG_USB_EHCI_OMAP
-/*#define CONFIG_EHCI_DCACHE*/ /* leave it disabled for now */
#define CONFIG_OMAP_EHCI_PHY1_RESET_GPIO 147
#define CONFIG_USB_ULPI
diff --git a/include/configs/sequoia.h b/include/configs/sequoia.h
index 8e6954e..dd5d7cd 100644
--- a/include/configs/sequoia.h
+++ b/include/configs/sequoia.h
@@ -288,9 +288,6 @@
#define CONFIG_EHCI_HCD_INIT_AFTER_RESET
#define CONFIG_EHCI_MMIO_BIG_ENDIAN
#define CONFIG_EHCI_DESC_BIG_ENDIAN
-#ifdef CONFIG_4xx_DCACHE
-#define CONFIG_EHCI_DCACHE
-#endif
#else /* CONFIG_USB_EHCI */
#define CONFIG_USB_OHCI_NEW
#define CONFIG_SYS_OHCI_BE_CONTROLLER
diff --git a/include/configs/tam3517-common.h b/include/configs/tam3517-common.h
index dd7757c..ac534ac 100644
--- a/include/configs/tam3517-common.h
+++ b/include/configs/tam3517-common.h
@@ -106,8 +106,6 @@
#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3
#define CONFIG_USB_STORAGE
-/* #define CONFIG_EHCI_DCACHE */
-
/* commands to include */
#include <config_cmd_default.h>
diff --git a/include/configs/tegra20-common.h b/include/configs/tegra20-common.h
index dc7444d..9d532f4 100644
--- a/include/configs/tegra20-common.h
+++ b/include/configs/tegra20-common.h
@@ -100,7 +100,6 @@
*/
#define CONFIG_USB_EHCI_TXFIFO_THRESH 10
#define CONFIG_EHCI_IS_TDI
-#define CONFIG_EHCI_DCACHE
/* Total I2C ports on Tegra20 */
#define TEGRA_I2C_NUM_CONTROLLERS 4
diff --git a/include/configs/vct.h b/include/configs/vct.h
index b4b0949..7aeb668 100644
--- a/include/configs/vct.h
+++ b/include/configs/vct.h
@@ -136,7 +136,6 @@
*/
#define CONFIG_USB_EHCI /* Enable EHCI USB support */
#define CONFIG_USB_EHCI_VCT /* on VCT platform */
-#define CONFIG_EHCI_DCACHE /* with dcache handling support */
#define CONFIG_EHCI_MMIO_BIG_ENDIAN
#define CONFIG_EHCI_DESC_BIG_ENDIAN
#define CONFIG_EHCI_IS_TDI
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] boards: remove the no longer used CONFIG_EHCI_DCACHE
2012-10-22 20:35 [U-Boot] [PATCH] boards: remove the no longer used CONFIG_EHCI_DCACHE Jeroen Hofstee
@ 2012-10-22 20:40 ` Marek Vasut
2012-10-22 21:47 ` stefano babic
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2012-10-22 20:40 UTC (permalink / raw)
To: u-boot
Dear Jeroen Hofstee,
> CONFIG_EHCI_DCACHE was removed by commit b8adb12
> "USB: Drop cache flush bloat in EHCI-HCD". Remove the defines from
> the boards configs as well.
>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> cc: Marek Vasut <marex@denx.de>
> cc: Stefan Roese <sr@denx.de>
> cc: Tom Rini <trini@ti.com>
> cc: Wolfgang Denk <wd@denx.de>
> cc: Thierry Reding <thierry.reding@avionic-design.de>
> cc: Tom Warren <twarren@nvidia.com>
> cc: Stephen Warren <swarren@nvidia.com>
> cc: Stefano Babic <sbabic@denx.de>
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] boards: remove the no longer used CONFIG_EHCI_DCACHE
2012-10-22 20:35 [U-Boot] [PATCH] boards: remove the no longer used CONFIG_EHCI_DCACHE Jeroen Hofstee
2012-10-22 20:40 ` Marek Vasut
@ 2012-10-22 21:47 ` stefano babic
2012-10-23 7:23 ` Stefan Roese
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: stefano babic @ 2012-10-22 21:47 UTC (permalink / raw)
To: u-boot
Am 22/10/2012 22:35, schrieb Jeroen Hofstee:
> CONFIG_EHCI_DCACHE was removed by commit b8adb12
> "USB: Drop cache flush bloat in EHCI-HCD". Remove the defines from
> the boards configs as well.
>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> cc: Marek Vasut <marex@denx.de>
> cc: Stefan Roese <sr@denx.de>
> cc: Tom Rini <trini@ti.com>
> cc: Wolfgang Denk <wd@denx.de>
> cc: Thierry Reding <thierry.reding@avionic-design.de>
> cc: Tom Warren <twarren@nvidia.com>
> cc: Stephen Warren <swarren@nvidia.com>
> cc: Stefano Babic <sbabic@denx.de>
> ---
> include/configs/lwmon5.h | 1 -
> include/configs/mcx.h | 1 -
> include/configs/omap3_beagle.h | 1 -
> include/configs/sequoia.h | 3 ---
> include/configs/tam3517-common.h | 2 --
> include/configs/tegra20-common.h | 1 -
> include/configs/vct.h | 1 -
> 7 files changed, 10 deletions(-)
>
> diff --git a/include/configs/lwmon5.h b/include/configs/lwmon5.h
> index 2d33ebc..2ebcd16 100644
> --- a/include/configs/lwmon5.h
> +++ b/include/configs/lwmon5.h
> @@ -401,7 +401,6 @@
> #define CONFIG_USB_EHCI /* Enable EHCI USB support */
> #define CONFIG_USB_EHCI_PPC4XX /* on PPC4xx platform */
> #define CONFIG_SYS_PPC4XX_USB_ADDR 0xe0000300
> -#define CONFIG_EHCI_DCACHE /* with dcache handling support */
> #define CONFIG_EHCI_MMIO_BIG_ENDIAN
> #define CONFIG_EHCI_DESC_BIG_ENDIAN
> #define CONFIG_EHCI_HCD_INIT_AFTER_RESET /* re-init HCD after CMD_RESET */
> diff --git a/include/configs/mcx.h b/include/configs/mcx.h
> index 359522a..6251ab7 100644
> --- a/include/configs/mcx.h
> +++ b/include/configs/mcx.h
> @@ -114,7 +114,6 @@
> #define CONFIG_USB_EHCI_OMAP
> #define CONFIG_USB_ULPI
> #define CONFIG_USB_ULPI_VIEWPORT_OMAP
> -/*#define CONFIG_EHCI_DCACHE*/ /* leave it disabled for now */
> #define CONFIG_OMAP_EHCI_PHY1_RESET_GPIO 154
> #define CONFIG_OMAP_EHCI_PHY2_RESET_GPIO 152
> #define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3
> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> index f79f996..9d435ca 100644
> --- a/include/configs/omap3_beagle.h
> +++ b/include/configs/omap3_beagle.h
> @@ -131,7 +131,6 @@
> #define CONFIG_USB_EHCI
>
> #define CONFIG_USB_EHCI_OMAP
> -/*#define CONFIG_EHCI_DCACHE*/ /* leave it disabled for now */
> #define CONFIG_OMAP_EHCI_PHY1_RESET_GPIO 147
>
> #define CONFIG_USB_ULPI
> diff --git a/include/configs/sequoia.h b/include/configs/sequoia.h
> index 8e6954e..dd5d7cd 100644
> --- a/include/configs/sequoia.h
> +++ b/include/configs/sequoia.h
> @@ -288,9 +288,6 @@
> #define CONFIG_EHCI_HCD_INIT_AFTER_RESET
> #define CONFIG_EHCI_MMIO_BIG_ENDIAN
> #define CONFIG_EHCI_DESC_BIG_ENDIAN
> -#ifdef CONFIG_4xx_DCACHE
> -#define CONFIG_EHCI_DCACHE
> -#endif
> #else /* CONFIG_USB_EHCI */
> #define CONFIG_USB_OHCI_NEW
> #define CONFIG_SYS_OHCI_BE_CONTROLLER
> diff --git a/include/configs/tam3517-common.h b/include/configs/tam3517-common.h
> index dd7757c..ac534ac 100644
> --- a/include/configs/tam3517-common.h
> +++ b/include/configs/tam3517-common.h
> @@ -106,8 +106,6 @@
> #define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3
> #define CONFIG_USB_STORAGE
>
> -/* #define CONFIG_EHCI_DCACHE */
> -
> /* commands to include */
> #include <config_cmd_default.h>
>
> diff --git a/include/configs/tegra20-common.h b/include/configs/tegra20-common.h
> index dc7444d..9d532f4 100644
> --- a/include/configs/tegra20-common.h
> +++ b/include/configs/tegra20-common.h
> @@ -100,7 +100,6 @@
> */
> #define CONFIG_USB_EHCI_TXFIFO_THRESH 10
> #define CONFIG_EHCI_IS_TDI
> -#define CONFIG_EHCI_DCACHE
>
> /* Total I2C ports on Tegra20 */
> #define TEGRA_I2C_NUM_CONTROLLERS 4
> diff --git a/include/configs/vct.h b/include/configs/vct.h
> index b4b0949..7aeb668 100644
> --- a/include/configs/vct.h
> +++ b/include/configs/vct.h
> @@ -136,7 +136,6 @@
> */
> #define CONFIG_USB_EHCI /* Enable EHCI USB support */
> #define CONFIG_USB_EHCI_VCT /* on VCT platform */
> -#define CONFIG_EHCI_DCACHE /* with dcache handling support */
> #define CONFIG_EHCI_MMIO_BIG_ENDIAN
> #define CONFIG_EHCI_DESC_BIG_ENDIAN
> #define CONFIG_EHCI_IS_TDI
>
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] boards: remove the no longer used CONFIG_EHCI_DCACHE
2012-10-22 20:35 [U-Boot] [PATCH] boards: remove the no longer used CONFIG_EHCI_DCACHE Jeroen Hofstee
2012-10-22 20:40 ` Marek Vasut
2012-10-22 21:47 ` stefano babic
@ 2012-10-23 7:23 ` Stefan Roese
2012-10-23 7:27 ` Thierry Reding
2012-10-23 15:16 ` Tom Rini
4 siblings, 0 replies; 7+ messages in thread
From: Stefan Roese @ 2012-10-23 7:23 UTC (permalink / raw)
To: u-boot
On 10/22/2012 10:35 PM, Jeroen Hofstee wrote:
> CONFIG_EHCI_DCACHE was removed by commit b8adb12
> "USB: Drop cache flush bloat in EHCI-HCD". Remove the defines from
> the boards configs as well.
>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> cc: Marek Vasut <marex@denx.de>
> cc: Stefan Roese <sr@denx.de>
> cc: Tom Rini <trini@ti.com>
> cc: Wolfgang Denk <wd@denx.de>
> cc: Thierry Reding <thierry.reding@avionic-design.de>
> cc: Tom Warren <twarren@nvidia.com>
> cc: Stephen Warren <swarren@nvidia.com>
> cc: Stefano Babic <sbabic@denx.de>
Acked-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] boards: remove the no longer used CONFIG_EHCI_DCACHE
2012-10-22 20:35 [U-Boot] [PATCH] boards: remove the no longer used CONFIG_EHCI_DCACHE Jeroen Hofstee
` (2 preceding siblings ...)
2012-10-23 7:23 ` Stefan Roese
@ 2012-10-23 7:27 ` Thierry Reding
2012-10-23 15:16 ` Tom Rini
4 siblings, 0 replies; 7+ messages in thread
From: Thierry Reding @ 2012-10-23 7:27 UTC (permalink / raw)
To: u-boot
On Mon, Oct 22, 2012 at 10:35:46PM +0200, Jeroen Hofstee wrote:
> CONFIG_EHCI_DCACHE was removed by commit b8adb12
> "USB: Drop cache flush bloat in EHCI-HCD". Remove the defines from
> the boards configs as well.
>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> cc: Marek Vasut <marex@denx.de>
> cc: Stefan Roese <sr@denx.de>
> cc: Tom Rini <trini@ti.com>
> cc: Wolfgang Denk <wd@denx.de>
> cc: Thierry Reding <thierry.reding@avionic-design.de>
> cc: Tom Warren <twarren@nvidia.com>
> cc: Stephen Warren <swarren@nvidia.com>
> cc: Stefano Babic <sbabic@denx.de>
> ---
> include/configs/lwmon5.h | 1 -
> include/configs/mcx.h | 1 -
> include/configs/omap3_beagle.h | 1 -
> include/configs/sequoia.h | 3 ---
> include/configs/tam3517-common.h | 2 --
> include/configs/tegra20-common.h | 1 -
> include/configs/vct.h | 1 -
> 7 files changed, 10 deletions(-)
Acked-by: Thierry Reding <thierry.reding@avionic-design.de>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121023/3e55e3ed/attachment.pgp>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] boards: remove the no longer used CONFIG_EHCI_DCACHE
2012-10-22 20:35 [U-Boot] [PATCH] boards: remove the no longer used CONFIG_EHCI_DCACHE Jeroen Hofstee
` (3 preceding siblings ...)
2012-10-23 7:27 ` Thierry Reding
@ 2012-10-23 15:16 ` Tom Rini
2012-10-23 22:05 ` Marek Vasut
4 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2012-10-23 15:16 UTC (permalink / raw)
To: u-boot
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/22/12 13:35, Jeroen Hofstee wrote:
> CONFIG_EHCI_DCACHE was removed by commit b8adb12 "USB: Drop cache
> flush bloat in EHCI-HCD". Remove the defines from the boards
> configs as well.
>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl> cc: Marek
> Vasut <marex@denx.de> cc: Stefan Roese <sr@denx.de> cc: Tom Rini
> <trini@ti.com> cc: Wolfgang Denk <wd@denx.de> cc: Thierry Reding
> <thierry.reding@avionic-design.de> cc: Tom Warren
> <twarren@nvidia.com> cc: Stephen Warren <swarren@nvidia.com> cc:
> Stefano Babic <sbabic@denx.de>
Acked-by: Tom Rini <trini@ti.com>
I'll give this a few more days for acks and then pick it up for
master, thanks!
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iQIcBAEBAgAGBQJQhrTqAAoJENk4IS6UOR1Ww5cP/RtQ3KMUmeMR3xCKpjaF8sAD
yeX2PeDA1DtJZTucXAdFCCTKXfCluNGId7AFKdM1+BF4BQsqVf8E1LKuWCGL6O1h
RjoDIz6a1wzOrkxvTnoazVUtNr9SadDIpYYR/bHHxJqn6zxXpPpSURoJnbkswdmr
DUGHEfeNJ2szA8ixOWaTmDd1lwfl4HhTiThWFpkH044R7JbfJI7yyQmor5St/u84
pJZDXMshlJui7m9tr0KZGR4aHE4rYZqRLRSedCBQfYlHrVWXRdysHKlWPpv+fPh/
Iac7M5lGjW/LKfFAkQ0vl1P6/2Kc1BuqJyxjxPaFXzWzIAQC7OxsCyKO2Eu3u1h8
EjYAqqwvCVrBfZtLfx9rXF7HGg1QdjTh+oCPboXn2zlvA6/axglxEbI9O/9SOJK/
fFOlYYc6Vos/vQCF0xFbRK7FnYWuUCKlNls9W9qR8R11PkioEmW9w8jtj5OxEqqL
smu6EE16A51Ik5hUi78+xqxt23YUbB5iHrVXpSKkJUpb1afvtwLa/Xeqi7AtBvGw
JcAIIhBDUfrQaJzrw1yi8cXNi/hJTx0qsKw9rXxre+WY9b7vDm7hqikQnH3OeOYt
2FRp2OOFwuuEX/ttexQc+Cg0AXPtoxuDmfTD0dMPyh577ZS56ga1mywGHSezeC+S
wzyjqxnNtCdqL2ZMqi1T
=KuZK
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] boards: remove the no longer used CONFIG_EHCI_DCACHE
2012-10-23 15:16 ` Tom Rini
@ 2012-10-23 22:05 ` Marek Vasut
0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2012-10-23 22:05 UTC (permalink / raw)
To: u-boot
Dear Tom Rini,
> On 10/22/12 13:35, Jeroen Hofstee wrote:
> > CONFIG_EHCI_DCACHE was removed by commit b8adb12 "USB: Drop cache
> > flush bloat in EHCI-HCD". Remove the defines from the boards
> > configs as well.
> >
> > Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl> cc: Marek
> > Vasut <marex@denx.de> cc: Stefan Roese <sr@denx.de> cc: Tom Rini
> > <trini@ti.com> cc: Wolfgang Denk <wd@denx.de> cc: Thierry Reding
> > <thierry.reding@avionic-design.de> cc: Tom Warren
> > <twarren@nvidia.com> cc: Stephen Warren <swarren@nvidia.com> cc:
> > Stefano Babic <sbabic@denx.de>
>
> Acked-by: Tom Rini <trini@ti.com>
>
> I'll give this a few more days for acks and then pick it up for
> master, thanks!
I'll pull this into USB actually.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-10-23 22:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-22 20:35 [U-Boot] [PATCH] boards: remove the no longer used CONFIG_EHCI_DCACHE Jeroen Hofstee
2012-10-22 20:40 ` Marek Vasut
2012-10-22 21:47 ` stefano babic
2012-10-23 7:23 ` Stefan Roese
2012-10-23 7:27 ` Thierry Reding
2012-10-23 15:16 ` Tom Rini
2012-10-23 22:05 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox