* [U-Boot] [PATCH 0/2] socfpga/spl: Cleanup
@ 2012-10-23 10:19 Vikram Narayanan
2012-10-23 10:21 ` [U-Boot] [PATCH 1/2] socfpga/spl: Remove timer_init from spl_board_init Vikram Narayanan
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Vikram Narayanan @ 2012-10-23 10:19 UTC (permalink / raw)
To: u-boot
Cleanups for SPL/socfpga.
Cc: Dinh Nguyen <dinguyen@altera.com>
Vikram Narayanan (2):
arm/socfpga: Remove timer_init from spl_board_init
socfpga/spl: Remove malloc.h
arch/arm/cpu/armv7/socfpga/spl.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
--
1.7.4.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 1/2] socfpga/spl: Remove timer_init from spl_board_init
2012-10-23 10:19 [U-Boot] [PATCH 0/2] socfpga/spl: Cleanup Vikram Narayanan
@ 2012-10-23 10:21 ` Vikram Narayanan
2012-11-04 15:22 ` Albert ARIBAUD
2012-10-23 10:22 ` [U-Boot] [PATCH 2/2] socfpga/spl: Remove malloc.h Vikram Narayanan
2012-10-23 16:27 ` [U-Boot] [PATCH 0/2] socfpga/spl: Cleanup Dinh Nguyen
2 siblings, 1 reply; 7+ messages in thread
From: Vikram Narayanan @ 2012-10-23 10:21 UTC (permalink / raw)
To: u-boot
Timer is initialized already in board_init_r function in
(common/spl/spl.c) No need to initialize it again
Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
Cc: Dinh Nguyen <dinguyen@altera.com>
---
arch/arm/cpu/armv7/socfpga/spl.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/arm/cpu/armv7/socfpga/spl.c b/arch/arm/cpu/armv7/socfpga/spl.c
index 944238b..23053fd 100644
--- a/arch/arm/cpu/armv7/socfpga/spl.c
+++ b/arch/arm/cpu/armv7/socfpga/spl.c
@@ -37,9 +37,6 @@ u32 spl_boot_device(void)
*/
void spl_board_init(void)
{
- /* init timer for enabling delay function */
- timer_init();
-
/* de-assert reset for peripherals and bridges based on handoff */
reset_deassert_peripherals_handoff();
--
1.7.4.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 2/2] socfpga/spl: Remove malloc.h
2012-10-23 10:19 [U-Boot] [PATCH 0/2] socfpga/spl: Cleanup Vikram Narayanan
2012-10-23 10:21 ` [U-Boot] [PATCH 1/2] socfpga/spl: Remove timer_init from spl_board_init Vikram Narayanan
@ 2012-10-23 10:22 ` Vikram Narayanan
2012-11-10 10:33 ` Albert ARIBAUD
2012-10-23 16:27 ` [U-Boot] [PATCH 0/2] socfpga/spl: Cleanup Dinh Nguyen
2 siblings, 1 reply; 7+ messages in thread
From: Vikram Narayanan @ 2012-10-23 10:22 UTC (permalink / raw)
To: u-boot
Remove unused header
Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
---
arch/arm/cpu/armv7/socfpga/spl.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/cpu/armv7/socfpga/spl.c b/arch/arm/cpu/armv7/socfpga/spl.c
index 23053fd..84216eb 100644
--- a/arch/arm/cpu/armv7/socfpga/spl.c
+++ b/arch/arm/cpu/armv7/socfpga/spl.c
@@ -21,7 +21,6 @@
#include <asm/utils.h>
#include <version.h>
#include <image.h>
-#include <malloc.h>
#include <asm/arch/reset_manager.h>
#include <spl.h>
--
1.7.4.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 0/2] socfpga/spl: Cleanup
2012-10-23 10:19 [U-Boot] [PATCH 0/2] socfpga/spl: Cleanup Vikram Narayanan
2012-10-23 10:21 ` [U-Boot] [PATCH 1/2] socfpga/spl: Remove timer_init from spl_board_init Vikram Narayanan
2012-10-23 10:22 ` [U-Boot] [PATCH 2/2] socfpga/spl: Remove malloc.h Vikram Narayanan
@ 2012-10-23 16:27 ` Dinh Nguyen
2012-10-24 22:46 ` Pavel Machek
2 siblings, 1 reply; 7+ messages in thread
From: Dinh Nguyen @ 2012-10-23 16:27 UTC (permalink / raw)
To: u-boot
Hi Vikram,
On Tue, 2012-10-23 at 15:49 +0530, Vikram Narayanan wrote:
> Cleanups for SPL/socfpga.
>
> Cc: Dinh Nguyen <dinguyen@altera.com>
>
> Vikram Narayanan (2):
> arm/socfpga: Remove timer_init from spl_board_init
> socfpga/spl: Remove malloc.h
Do you need to split up the patches? Otherwise,
Acked-by: Dinh Nguyen <dinguyen@altera.com>
Dinh
>
> arch/arm/cpu/armv7/socfpga/spl.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 0/2] socfpga/spl: Cleanup
2012-10-23 16:27 ` [U-Boot] [PATCH 0/2] socfpga/spl: Cleanup Dinh Nguyen
@ 2012-10-24 22:46 ` Pavel Machek
0 siblings, 0 replies; 7+ messages in thread
From: Pavel Machek @ 2012-10-24 22:46 UTC (permalink / raw)
To: u-boot
On Tue 2012-10-23 10:27:41, Dinh Nguyen wrote:
> Hi Vikram,
>
> On Tue, 2012-10-23 at 15:49 +0530, Vikram Narayanan wrote:
> > Cleanups for SPL/socfpga.
> >
> > Cc: Dinh Nguyen <dinguyen@altera.com>
> >
> > Vikram Narayanan (2):
> > arm/socfpga: Remove timer_init from spl_board_init
> > socfpga/spl: Remove malloc.h
>
> Do you need to split up the patches? Otherwise,
>
> Acked-by: Dinh Nguyen <dinguyen@altera.com>
The patches are single-(functional)-line each, I think they are split
up pretty perfectly.
Acked-by: Pavel Machek <pavel@denx.de>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 1/2] socfpga/spl: Remove timer_init from spl_board_init
2012-10-23 10:21 ` [U-Boot] [PATCH 1/2] socfpga/spl: Remove timer_init from spl_board_init Vikram Narayanan
@ 2012-11-04 15:22 ` Albert ARIBAUD
0 siblings, 0 replies; 7+ messages in thread
From: Albert ARIBAUD @ 2012-11-04 15:22 UTC (permalink / raw)
To: u-boot
Hi Vikram,
On Tue, 23 Oct 2012 15:51:16 +0530, Vikram Narayanan
<vikram186@gmail.com> wrote:
> Timer is initialized already in board_init_r function in
> (common/spl/spl.c) No need to initialize it again
>
> Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> ---
> arch/arm/cpu/armv7/socfpga/spl.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/socfpga/spl.c b/arch/arm/cpu/armv7/socfpga/spl.c
> index 944238b..23053fd 100644
> --- a/arch/arm/cpu/armv7/socfpga/spl.c
> +++ b/arch/arm/cpu/armv7/socfpga/spl.c
> @@ -37,9 +37,6 @@ u32 spl_boot_device(void)
> */
> void spl_board_init(void)
> {
> - /* init timer for enabling delay function */
> - timer_init();
> -
> /* de-assert reset for peripherals and bridges based on handoff */
> reset_deassert_peripherals_handoff();
>
Applied to u-boot-arm/master, thanks!
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 2/2] socfpga/spl: Remove malloc.h
2012-10-23 10:22 ` [U-Boot] [PATCH 2/2] socfpga/spl: Remove malloc.h Vikram Narayanan
@ 2012-11-10 10:33 ` Albert ARIBAUD
0 siblings, 0 replies; 7+ messages in thread
From: Albert ARIBAUD @ 2012-11-10 10:33 UTC (permalink / raw)
To: u-boot
Hi Vikram,
On Tue, 23 Oct 2012 15:52:53 +0530, Vikram Narayanan
<vikram186@gmail.com> wrote:
> Remove unused header
>
> Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
> ---
> arch/arm/cpu/armv7/socfpga/spl.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/socfpga/spl.c b/arch/arm/cpu/armv7/socfpga/spl.c
> index 23053fd..84216eb 100644
> --- a/arch/arm/cpu/armv7/socfpga/spl.c
> +++ b/arch/arm/cpu/armv7/socfpga/spl.c
> @@ -21,7 +21,6 @@
> #include <asm/utils.h>
> #include <version.h>
> #include <image.h>
> -#include <malloc.h>
> #include <asm/arch/reset_manager.h>
> #include <spl.h>
>
Note: this was applied to u-boot-arm/master along with 1/2.
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-11-10 10:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-23 10:19 [U-Boot] [PATCH 0/2] socfpga/spl: Cleanup Vikram Narayanan
2012-10-23 10:21 ` [U-Boot] [PATCH 1/2] socfpga/spl: Remove timer_init from spl_board_init Vikram Narayanan
2012-11-04 15:22 ` Albert ARIBAUD
2012-10-23 10:22 ` [U-Boot] [PATCH 2/2] socfpga/spl: Remove malloc.h Vikram Narayanan
2012-11-10 10:33 ` Albert ARIBAUD
2012-10-23 16:27 ` [U-Boot] [PATCH 0/2] socfpga/spl: Cleanup Dinh Nguyen
2012-10-24 22:46 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox