From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements
Date: Tue, 23 Oct 2012 10:31:27 -0600 [thread overview]
Message-ID: <5086C65F.6050305@wwwdotorg.org> (raw)
In-Reply-To: <201210230926.31221.marex@denx.de>
On 10/23/2012 01:26 AM, Marek Vasut wrote:
> Dear Allen Martin,
>
>> Change usb_kbd driver to obey alignment requirements for USB DMA on
>> the buffer used for data transfer. This is necessary for
>> architectures that enable dcache and enable USB DMA.
>> @@ -426,7 +426,7 @@ static int usb_kbd_probe(struct usb_device *dev,
>> unsigned int ifnum)
>>
>> USB_KBD_PRINTF("USB KBD: found set protocol...\n");
>>
>> - data = malloc(sizeof(struct usb_kbd_pdata));
>> + data = memalign(USB_DMA_MINALIGN, sizeof(struct usb_kbd_pdata));
>
> Don't we have ALLOC_CACHE_ALIGN_BUFFER and such stuff in include/common.h for
> this purpose ?
That's for stack-based data structures, whereas this data structure
sticks around for more than the duration of this function.
next prev parent reply other threads:[~2012-10-23 16:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 5:47 [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements Allen Martin
2012-10-23 5:47 ` [U-Boot] [PATCH v2 2/3] tegra: move TEGRA_DEVICE_SETTINGS to tegra-common-post.h Allen Martin
2012-10-23 7:27 ` Marek Vasut
2012-10-23 16:36 ` Stephen Warren
2012-10-23 22:01 ` Marek Vasut
2012-10-23 22:18 ` Stephen Warren
2012-10-24 0:30 ` Allen Martin
2012-11-02 20:06 ` Allen Martin
2012-11-02 20:40 ` Marek Vasut
2012-10-23 16:41 ` Stephen Warren
2012-10-23 5:47 ` [U-Boot] [PATCH v2 3/3] tegra: Enable USB keyboard Allen Martin
2012-10-23 7:26 ` [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements Marek Vasut
2012-10-23 16:31 ` Stephen Warren [this message]
2012-10-23 16:51 ` Allen Martin
2012-10-23 22:04 ` Marek Vasut
2012-10-23 16:51 ` Stephen Warren
2012-10-23 17:02 ` Allen Martin
2012-10-23 22:03 ` Marek Vasut
2012-10-24 0:39 ` Allen Martin
2012-10-24 0:46 ` Allen Martin
2012-10-24 7:31 ` Marek Vasut
2012-10-24 17:24 ` Allen Martin
2012-10-24 20:17 ` Marek Vasut
2012-10-24 20:41 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5086C65F.6050305@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox