From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_Bie=DFmann?= Date: Wed, 24 Oct 2012 09:57:43 +0200 Subject: [U-Boot] [PATCH] common/lcd: fix eldk 4.2 compile warning In-Reply-To: <201210240009.24660.marex@denx.de> References: <1350992711-352-1-git-send-email-andreas.devel@googlemail.com> <201210231414.10173.marex@denx.de> <50868F86.4060405@gmail.com> <201210240009.24660.marex@denx.de> Message-ID: <50879F77.8070601@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Marek Vasut, On 24.10.2012 00:09, Marek Vasut wrote: > Dear Andreas Bie?mann, > > [..] >> >> yes, I am. This patch is runtime tested on an at91sam9263ek. >> >> I first tried to consolidate the cmap and just use the ushort as in the >> else path. But unfortunately this require some more rework of this driver. > > Can you do such rework? You're the atmel guy afterall. I can do such rework, although I have currently not much time to work on that issue. Until 2013.01 release in January this should be doable but not in the next few days until MW closes. >>> Why is the atmel LCD driver so separate >>> anyway? >> >> Sorry, I don't know. This should really be reworked some time. >> But I think for now this quick fix can be applied to silence your >> eldk-4.2 warning. > > I don't like hiding problems, can we aim for a proper solution please? You are right, we should do so. Best regards Andreas Bie?mann