From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: add environment control for SERIAL_MULTI
Date: Thu, 25 Oct 2012 16:45:48 -0600 [thread overview]
Message-ID: <5089C11C.7030407@wwwdotorg.org> (raw)
In-Reply-To: <CANr=Z=bFYL=qh3PXbx8uiB5pbGWTpKBkuh2oxWK0R7zsk+fJFQ@mail.gmail.com>
On 10/25/2012 04:36 PM, Joe Hershberger wrote:
> Hi Allen,
>
> On Thu, Oct 25, 2012 at 4:59 PM, Allen Martin <amartin@nvidia.com> wrote:
>> Add a new special environment variable "serial" that allows selection
>> of serial device when CONFIG_SERIAL_MULTI is defined. This replaces
>> the existing calls to serial_assign() from cmd_nvedit.c and iomux.c
>> that were not doing anything.
...
> Changes to this directly conflict with the environment callback series
> I sent out RFC (soon be be a real series). Can we hold off on this
> until that happens?
The problem here is that serial output on Tegra simply doesn't work
(after some point in boot?) without this patch. It seems better to get
everything working before adding new features doesn't it? Otherwise, if
the environment callback stuff (or any other change right now) breaks
something Tegra-specific, there would be no way to identify which change
broke it.
next prev parent reply other threads:[~2012-10-25 22:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 21:59 [U-Boot] [PATCH] serial: add environment control for SERIAL_MULTI Allen Martin
2012-10-25 22:29 ` Marek Vasut
2012-10-25 22:36 ` Tom Rini
2012-10-25 22:36 ` Joe Hershberger
2012-10-25 22:45 ` Stephen Warren [this message]
2012-10-25 22:47 ` Joe Hershberger
2012-10-25 22:53 ` Allen Martin
2012-10-25 23:18 ` Joe Hershberger
2012-10-25 23:21 ` Allen Martin
2012-10-25 22:43 ` Stephen Warren
2012-10-25 22:46 ` Joe Hershberger
2012-10-25 22:50 ` Allen Martin
2012-10-25 23:17 ` Joe Hershberger
2012-10-26 10:27 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5089C11C.7030407@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox