[U-Boot] S-o-b entries for bcm2708 SDHCI driver in the downstream R.Pi Linux kernel

[U-Boot] S-o-b entries for bcm2708 SDHCI driver in the downstream R.Pi Linux kernel

[Stephen Warren]

(Sorry for the resend; I sent this to the wrong U-Boot mailing list the
first time around)

Dom, ddv2005, Gray,

I'm trying to get Signed-off-by lines for all code in the Raspberry Pi
Linux kernel trees related to the SDHCI driver (or just everything). The
list of relevant commits for SDHCI is below. Can you please check
Documentation/SubmittingPatches in the kernel source tree, and if you're
able to, provide your Signed-of-by lines for all of the patches I list
below that were either authored by you, or passed through you (the
latter I assume mainly in the case of Dom who applied these to git).

Related, do you know who the following person is: Grigori Goronzy
<greg@blackbox>; he's the author of at least one patch, but the email
address is invalid.

Dom, it'd be great if you could obtain the appropriate S-o-b lines from
all contributors to your kernel trees, then rebase these branches and
add the appropriate S-o-bs to all the patches. If in the future you make
sure that all the git metadata and S-o-b entries are present and valid
in all the commits (full name and valid email address), we won't have to
go back to people and validate this after the fact again.

Note: the patch list below is every patch that touches the driver. It
may be possible to analyze each patch and find only those that touched
the specific subset of code that Oleksandr used for U-Boot. I can give
that a try if getting S-o-bs for all the patches proves problematic. Of
course, that will then simply defer the issue until someone attempts to
upstream the whole downstream Linux SDHCI driver into the upstream Linux
kernel...

Thanks very much!

rpi-3.2.27:

> 118e2d3 Allow the number of cycles delay between sdcard peripheral writes to be specified on command line with sdhci-bcm2708.cycle_delay
> 7042895 Enable low latency mode by default in sdcard driver. Can be disabled with sdhci-bcm2708.enable_llm=0
> 307d9fb Fix build for non-preempt case. Fix warning
> e886b45 Add low-latency mode to sdcard driver. Enable with sdhci-bcm2708.enable_llm=1. Thanks ddv2005.
> 2c671b9 Fix spinlock recursion in sdhci-bcm2708.c
> 147779e Add module parameter for missing_status quirk. sdhci-bcm2708.missing_status=0 may improve interrupt latency
> 31c350f sdhci-bcm2708: use multiblock-type transfers for single blocks
> 3a47543 sdhci-bcm2708: use extension FIFO to buffer DMA transfers
> 0bf2669 Add sync_after_dma module parameter
> f1da243 Use ndelay rather than udelay. Thanks lb

Who is lb?

> 63aa167 Fix bool/int error, part 2
> d34d49e Fix bool/int error
> d7afba1 sdhci-bcm2708: raise DMA sync timeout
> 84042ac Allow emmc clock to be specified as command line parameter
> 70b125d sdhci-bcm2708: assume 50 MHz eMMC clock
> d7156c5 sdhci-bcm2708: add allow_highspeed parameter
> 8f82daa sdhci-bcm2708: add additional quirks
> 6ab6d02 sdhci-bcm2708: remove custom clock handling
> 8390fb8 sdhci-bcm2708: speed up DMA sync
> 2d05297 sdcard patch improvements from naren

Who is naren?

> e9382f7 possible fix for sdcard missing status. Thank naren
> 2456b9f Replace #if 1 sections by local configuration #defines (tidy)
> 8a93b2a Fix problem with dma that could corrupt sdcard, especially when L2 enabled
> 5961574 Fix for mmc timeouts when erasing multiple blocks
> 031ee3e Main bcm2708 linux port

Are these actually all authored by who git says they are? I notice that
the two commits I called out above have a git authorship field of Dom
Cobley, even though the patch subject implies someone else wrote them.

rpi-3.6.y:

> a2386d3 Fix up issues with rebase
> f34c715 Allow the number of cycles delay between sdcard peripheral writes to be specified on command line with sdhci-bcm2708.cycle_delay
> f0dbf1e Enable low latency mode by default in sdcard driver. Can be disabled with sdhci-bcm2708.enable_llm=0
> da819bb Fix build for non-preempt case. Fix warning
> f26afe4 Add low-latency mode to sdcard driver. Enable with sdhci-bcm2708.enable_llm=1. Thanks ddv2005.
> 641bd2c Fix spinlock recursion in sdhci-bcm2708.c
> ee410b8 Add module parameter for missing_status quirk. sdhci-bcm2708.missing_status=0 may improve interrupt latency
> e1ccc32 sdhci-bcm2708: use multiblock-type transfers for single blocks
> 34eec60 sdhci-bcm2708: use extension FIFO to buffer DMA transfers
> 1245667 Add sync_after_dma module parameter
> 0b047fb Use ndelay rather than udelay. Thanks lb
> 234c311 Fix bool/int error, part 2
> 27f5be9 Fix bool/int error
> ab619f6 sdhci-bcm2708: raise DMA sync timeout
> 1b89d0c Allow emmc clock to be specified as command line parameter
> 5109353 sdhci-bcm2708: assume 50 MHz eMMC clock
> ce8e5cb sdhci-bcm2708: add allow_highspeed parameter
> aa86832 sdhci-bcm2708: add additional quirks
> e2076c4 sdhci-bcm2708: remove custom clock handling
> f354b15 sdhci-bcm2708: speed up DMA sync
> 9c9780e sdcard patch improvements from naren
> d47f5ca possible fix for sdcard missing status. Thank naren
> 1ba126b Replace #if 1 sections by local configuration #defines (tidy)
> 7a69d91 Fix problem with dma that could corrupt sdcard, especially when L2 enabled
> f5fe324 Fix for mmc timeouts when erasing multiple blocks
> f5b930b Main bcm2708 linux port

[U-Boot] S-o-b entries for bcm2708 SDHCI driver in the downstream R.Pi Linux kernel

[Stephen Warren]

On 10/26/2012 10:54 PM, Stephen Warren wrote:
> (Sorry for the resend; I sent this to the wrong U-Boot mailing list the
> first time around)
> 
> Dom, ddv2005, Gray,
> 
> I'm trying to get Signed-off-by lines for all code in the Raspberry Pi
> Linux kernel trees related to the SDHCI driver (or just everything). The
> list of relevant commits for SDHCI is below. Can you please check
> Documentation/SubmittingPatches in the kernel source tree, and if you're
> able to, provide your Signed-of-by lines for all of the patches I list
> below that were either authored by you, or passed through you (the
> latter I assume mainly in the case of Dom who applied these to git).

I've taken a closer look at the downstream Raspberry Pi kernel trees and
I see that the very first bcm2708 commit in the rpi-3.6.y branch
contains all the code that's been used by the U-Boot MMC driver port.

> commit f5b930be71d6de64c3264b2f9eff4a4079d50c14
> Author:     popcornmix <popcornmix@gmail.com>
> AuthorDate: Tue Jan 17 19:20:11 2012 +0000
> Commit:     popcornmix <popcornmix@gmail.com>
> CommitDate: Mon Oct 8 16:25:24 2012 +0100
> 
>     Main bcm2708 linux port
>     
>     Signed-off-by: popcornmix <popcornmix@gmail.com>

This commit is actually already signed off by popcornmix, and Dom Cobley
previously indicated that's him, and gave his permission to rewrite that
S-o-b to his real name.

Oleksandr, I believe that means that if you can give your S-o-b to the
U-Boot patch you created based on Dom's kernel code, we will be good to
go with the U-Boot patch I posted, and I can then repost it including
fixes for the review feedback it received.

Thanks!

[U-Boot] S-o-b entries for bcm2708 SDHCI driver in the downstream R.Pi Linux kernel

[Oleksandr Tymoshenko]

On 11/6/2012 6:58 PM, Stephen Warren wrote:
> On 10/26/2012 10:54 PM, Stephen Warren wrote:
>> (Sorry for the resend; I sent this to the wrong U-Boot mailing list the
>> first time around)
>>
>> Dom, ddv2005, Gray,
>>
>> I'm trying to get Signed-off-by lines for all code in the Raspberry Pi
>> Linux kernel trees related to the SDHCI driver (or just everything). The
>> list of relevant commits for SDHCI is below. Can you please check
>> Documentation/SubmittingPatches in the kernel source tree, and if you're
>> able to, provide your Signed-of-by lines for all of the patches I list
>> below that were either authored by you, or passed through you (the
>> latter I assume mainly in the case of Dom who applied these to git).
> I've taken a closer look at the downstream Raspberry Pi kernel trees and
> I see that the very first bcm2708 commit in the rpi-3.6.y branch
> contains all the code that's been used by the U-Boot MMC driver port.
>
>> commit f5b930be71d6de64c3264b2f9eff4a4079d50c14
>> Author:     popcornmix <popcornmix@gmail.com>
>> AuthorDate: Tue Jan 17 19:20:11 2012 +0000
>> Commit:     popcornmix <popcornmix@gmail.com>
>> CommitDate: Mon Oct 8 16:25:24 2012 +0100
>>
>>      Main bcm2708 linux port
>>      
>>      Signed-off-by: popcornmix <popcornmix@gmail.com>
> This commit is actually already signed off by popcornmix, and Dom Cobley
> previously indicated that's him, and gave his permission to rewrite that
> S-o-b to his real name.
>
> Oleksandr, I believe that means that if you can give your S-o-b to the
> U-Boot patch you created based on Dom's kernel code, we will be good to
> go with the U-Boot patch I posted, and I can then repost it including
> fixes for the review feedback it received.
>

I believe this is the only commit I made to SDHCI-related code:

commit c78b8ea9ae717432770843b825ea8a1a77f223fc
Author: Oleksandr Tymoshenko <gonzo@bluezbox.com>
Date:   Wed Jun 20 11:53:07 2012 -0700

     Add driper for R-Pi eMMC controller

Signed-off-by: Oleksandr Tymoshenko <gonzo@bluezbox.com>

[U-Boot] S-o-b entries for bcm2708 SDHCI driver in the downstream R.Pi Linux kernel

[Stephen Warren]

On 11/07/2012 01:47 PM, Oleksandr Tymoshenko wrote:
> On 11/6/2012 6:58 PM, Stephen Warren wrote:
>> On 10/26/2012 10:54 PM, Stephen Warren wrote:
>>> (Sorry for the resend; I sent this to the wrong U-Boot mailing list the
>>> first time around)
>>>
>>> Dom, ddv2005, Gray,
>>>
>>> I'm trying to get Signed-off-by lines for all code in the Raspberry Pi
>>> Linux kernel trees related to the SDHCI driver (or just everything). The
>>> list of relevant commits for SDHCI is below. Can you please check
>>> Documentation/SubmittingPatches in the kernel source tree, and if you're
>>> able to, provide your Signed-of-by lines for all of the patches I list
>>> below that were either authored by you, or passed through you (the
>>> latter I assume mainly in the case of Dom who applied these to git).
>> I've taken a closer look at the downstream Raspberry Pi kernel trees and
>> I see that the very first bcm2708 commit in the rpi-3.6.y branch
>> contains all the code that's been used by the U-Boot MMC driver port.
>>
>>> commit f5b930be71d6de64c3264b2f9eff4a4079d50c14
>>> Author:     popcornmix <popcornmix@gmail.com>
>>> AuthorDate: Tue Jan 17 19:20:11 2012 +0000
>>> Commit:     popcornmix <popcornmix@gmail.com>
>>> CommitDate: Mon Oct 8 16:25:24 2012 +0100
>>>
>>>      Main bcm2708 linux port
>>>           Signed-off-by: popcornmix <popcornmix@gmail.com>
>> This commit is actually already signed off by popcornmix, and Dom Cobley
>> previously indicated that's him, and gave his permission to rewrite that
>> S-o-b to his real name.
>>
>> Oleksandr, I believe that means that if you can give your S-o-b to the
>> U-Boot patch you created based on Dom's kernel code, we will be good to
>> go with the U-Boot patch I posted, and I can then repost it including
>> fixes for the review feedback it received.
>>
> 
> I believe this is the only commit I made to SDHCI-related code:
> 
> commit c78b8ea9ae717432770843b825ea8a1a77f223fc
> Author: Oleksandr Tymoshenko <gonzo@bluezbox.com>
> Date:   Wed Jun 20 11:53:07 2012 -0700
> 
>     Add driper for R-Pi eMMC controller
> 
> Signed-off-by: Oleksandr Tymoshenko <gonzo@bluezbox.com>

Thanks for that S-o-b. I also picked up some of the code from the
following commit of yours:

commit 1c2b43a634955661d6f7b69459de00ffd1c2d7a6
Author: Oleksandr Tymoshenko <gonzo@bluezbox.com>
Date:   Tue Jul 3 19:57:37 2012 -0700

    Workaround insufficient timeouts in u-boot

[U-Boot] S-o-b entries for bcm2708 SDHCI driver in the downstream R.Pi Linux kernel

[Oleksandr Tymoshenko]

On 2012-11-07, at 9:38 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:

> On 11/07/2012 01:47 PM, Oleksandr Tymoshenko wrote:
>> On 11/6/2012 6:58 PM, Stephen Warren wrote:
>>> On 10/26/2012 10:54 PM, Stephen Warren wrote:
>>>> (Sorry for the resend; I sent this to the wrong U-Boot mailing list the
>>>> first time around)
>>>> 
>>>> Dom, ddv2005, Gray,
>>>> 
>>>> I'm trying to get Signed-off-by lines for all code in the Raspberry Pi
>>>> Linux kernel trees related to the SDHCI driver (or just everything). The
>>>> list of relevant commits for SDHCI is below. Can you please check
>>>> Documentation/SubmittingPatches in the kernel source tree, and if you're
>>>> able to, provide your Signed-of-by lines for all of the patches I list
>>>> below that were either authored by you, or passed through you (the
>>>> latter I assume mainly in the case of Dom who applied these to git).
>>> I've taken a closer look at the downstream Raspberry Pi kernel trees and
>>> I see that the very first bcm2708 commit in the rpi-3.6.y branch
>>> contains all the code that's been used by the U-Boot MMC driver port.
>>> 
>>>> commit f5b930be71d6de64c3264b2f9eff4a4079d50c14
>>>> Author:     popcornmix <popcornmix@gmail.com>
>>>> AuthorDate: Tue Jan 17 19:20:11 2012 +0000
>>>> Commit:     popcornmix <popcornmix@gmail.com>
>>>> CommitDate: Mon Oct 8 16:25:24 2012 +0100
>>>> 
>>>>     Main bcm2708 linux port
>>>>          Signed-off-by: popcornmix <popcornmix@gmail.com>
>>> This commit is actually already signed off by popcornmix, and Dom Cobley
>>> previously indicated that's him, and gave his permission to rewrite that
>>> S-o-b to his real name.
>>> 
>>> Oleksandr, I believe that means that if you can give your S-o-b to the
>>> U-Boot patch you created based on Dom's kernel code, we will be good to
>>> go with the U-Boot patch I posted, and I can then repost it including
>>> fixes for the review feedback it received.
>>> 
>> 
>> I believe this is the only commit I made to SDHCI-related code:
>> 
>> commit c78b8ea9ae717432770843b825ea8a1a77f223fc
>> Author: Oleksandr Tymoshenko <gonzo@bluezbox.com>
>> Date:   Wed Jun 20 11:53:07 2012 -0700
>> 
>>    Add driper for R-Pi eMMC controller
>> 
>> Signed-off-by: Oleksandr Tymoshenko <gonzo@bluezbox.com>
> 
> Thanks for that S-o-b. I also picked up some of the code from the
> following commit of yours:
> 
> commit 1c2b43a634955661d6f7b69459de00ffd1c2d7a6
> Author: Oleksandr Tymoshenko <gonzo@bluezbox.com>
> Date:   Tue Jul 3 19:57:37 2012 -0700
> 
>    Workaround insufficient timeouts in u-boot

commit 1c2b43a634955661d6f7b69459de00ffd1c2d7a6
Author: Oleksandr Tymoshenko <gonzo@bluezbox.com>
Date:   Tue Jul 3 19:57:37 2012 -0700

   Workaround insufficient timeouts in u-boot

 Signed-off-by: Oleksandr Tymoshenko <gonzo@bluezbox.com>