From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Sat, 27 Oct 2012 20:09:20 -0600 Subject: [U-Boot] [PATCH V3 5/5] ARM: tegra: don't request GPIO from Seaboard's SPL In-Reply-To: <20121027111533.4b2e9bf1@lilith> References: <1350922776-30909-1-git-send-email-swarren@wwwdotorg.org> <1350922776-30909-5-git-send-email-swarren@wwwdotorg.org> <20121027111533.4b2e9bf1@lilith> Message-ID: <508C93D0.4060400@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/27/2012 03:15 AM, Albert ARIBAUD wrote: > Hi Stephen, > > On Mon, 22 Oct 2012 10:19:36 -0600, Stephen Warren > wrote: > >> From: Stephen Warren >> >> Seaboard has a GPIO that switches an external mux between Tegra's debug >> UART and SPI flash. This is initialized from the SPL so that SPL debug >> output can be seen. Simplify the code that does this, and don't actually >> request the GPIO in the SPL; just program it. This saves ~4.5K from the >> size of the SPL, mostly BSS due to the large gpio_names[] table that is >> no longer required. This makes Seaboard's SPL fit within the current max >> size. > > Is it possible to reorder the patch series so that Seaboard (and > Ventana?) builds do not break temporarily between patch 2 and this > patch? It would be possibel, although I'd personally rather call out the issue explicitly with a build break; if the build succeeds, you end up using code that silently causes memory corruption. Of course, this issue has been around for a while, so perhaps hiding it for another couple extra commits wouldn't be a big deal. Plus, the build break proves the assert in the .lds file works:-) But it's not big deal either way; feel free to re-order the commits if you want.