U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Shimizu, Ryan" <Ryan.Shimizu@viasat.com>
To: "u-boot@lists.denx.de" <u-boot@lists.denx.de>
Cc: "joe.hershberger@ni.com" <joe.hershberger@ni.com>,
	"rfried.dev@gmail.com" <rfried.dev@gmail.com>,
	"sjg@chromium.org" <sjg@chromium.org>,
	"trini@konsulko.com" <trini@konsulko.com>
Subject: [PATCH] net: phy: Add missing RGMII internal delay cases to vsc8541_config
Date: Thu, 2 May 2024 10:23:53 +0000	[thread overview]
Message-ID: <508e6b33f72f427cb90d2606cc1cbb96@viasat.com> (raw)

Currently, vsc8541_config does not account for cases where RGMII
mode with internal delays on TX, RX or both are selected, even though
the device supports that functionality. Instead, it returns an
error when "rgmii-id", "rgmii-txid" or "rgmii-rxid" is selected
in its corresponding DT node.

Fix by adding missing RGMII internal delay modes to list of
fall-through cases so that when configured with modes "rgmii-id",
"rgmii-txid" or "rgmii-rxid", the internal delay registers get
updated correctly in vsc8531_vsc8541_clk_skew_config().

Signed-off-by: Ryan Shimizu <ryan.shimizu@viasat.com>
---

 drivers/net/phy/mscc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c
index bd9cd95297..7263887b9c 100644
--- a/drivers/net/phy/mscc.c
+++ b/drivers/net/phy/mscc.c
@@ -1371,6 +1371,9 @@ static int vsc8541_config(struct phy_device *phydev)
        case PHY_INTERFACE_MODE_GMII:
        case PHY_INTERFACE_MODE_RMII:
        case PHY_INTERFACE_MODE_RGMII:
+       case PHY_INTERFACE_MODE_RGMII_TXID:
+       case PHY_INTERFACE_MODE_RGMII_RXID:
+       case PHY_INTERFACE_MODE_RGMII_ID:
                retval = vsc8531_vsc8541_mac_config(phydev);
                if (retval != 0)
                        return retval;
--
2.34.1



                 reply	other threads:[~2024-05-02 13:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=508e6b33f72f427cb90d2606cc1cbb96@viasat.com \
    --to=ryan.shimizu@viasat.com \
    --cc=joe.hershberger@ni.com \
    --cc=rfried.dev@gmail.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox