From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] Custodian branch base commits
Date: Tue, 30 Oct 2012 11:35:41 -0600 [thread overview]
Message-ID: <50900FED.6040508@wwwdotorg.org> (raw)
The instructions at:
http://www.denx.de/wiki/U-Boot/CustodianGitTrees
... indicate that downstream branches should be rebased onto
${upstream}/master immediately prior to sending a pull request. I'm not
sure this is correct any more, given that upstream master branches now
pull in downstream branches via "git merge" rather than "git rebase".
Should that page be changed?
The question then becomes: What commit should downstream branches use as
their baseline. I assert that they should be free to choose any commit
in their upstream master branch (or merge in any upstream commit), or
any further upstream branch all the way up to u-boot/master.
As background, I want to send a commit to the Tegra tree that enables
use of CONFIG_CMD_FS_GENERIC, and additionally, re-write bootcmd in
Tegra's default environment to use the new shell commands that config
option enables.
However, the commits that implement CONFIG_CMD_FS_GENERIC are in
u-boot/master but not yet in u-boot-arm/master. So, Tegra's master
branch can't simply be based on current u-boot-arm/master, since if it
was, applying my patch would break functionality until it was merged
with u-boot/master and so picked up the actual implementation.
Hopefully, u-boot-arm/master will merge in (or get reset to)
u-boot/master fairly shortly. However, should Tegra's repo have to wait
for this?
Instead, I propose that 2nd-level custodians should be able to do
something like:
# (in u-boot-tegra.git, assuming everything is merged already)
git checkout master
git reset --hard u-boot/master
git am patch_that_depends_on_uboot_master
# send pull request to u-boot-arm/master
# (in u-boot-tegra.git, assuming some patches already applied locally)
git checkout master
git merge u-boot/master
git am patch_that_depends_on_uboot_master
# send pull request to u-boot-arm/master
This should work fine provided that u-boot/master and u-boot-arm/master
guarantee never to rebase. If they don't make that guarantee, then I
don't think we can be using merges at all anyway, so that shouldn't be
an issue.
What do people think?
next reply other threads:[~2012-10-30 17:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 17:35 Stephen Warren [this message]
2012-10-30 18:50 ` [U-Boot] Custodian branch base commits Wolfgang Denk
2012-10-30 18:55 ` Stephen Warren
2012-10-30 20:47 ` Wolfgang Denk
2012-10-30 21:10 ` Stephen Warren
2012-10-30 22:06 ` Wolfgang Denk
2012-10-30 22:20 ` Stephen Warren
2012-11-18 1:57 ` Jerry Van Baren
2012-10-30 21:19 ` Tom Rini
2012-10-31 16:56 ` Stephen Warren
2012-11-03 11:49 ` Albert ARIBAUD
2012-11-05 17:17 ` Stephen Warren
2012-11-05 19:39 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50900FED.6040508@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox