From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 30 Oct 2012 12:34:47 -0600 Subject: [U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port In-Reply-To: <1351601052.1434.20.camel@tellur> References: <1351588973-20699-1-git-send-email-dev@lynxeye.de> <201210301159.35457.marex@denx.de> <1351599137.1434.15.camel@tellur> <201210301333.32661.marex@denx.de> <1351601052.1434.20.camel@tellur> Message-ID: <50901DC7.1000506@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/30/2012 06:44 AM, Lucas Stach wrote: > Hi Marek, > > Am Dienstag, den 30.10.2012, 13:33 +0100 schrieb Marek Vasut: >> Dear Lucas Stach, >> >> [...] >> >>>>> -static int add_port(struct fdt_usb *config) >>>> >>>> Fix the comment instead of removing it? >>> >>> I don't think that this comment adds any real value. The whole function >>> which this comment refers to is removed and it's content split between >>> board_usb_init and ehci_hcd_init, which are self explanatory. >> >> Then add a proper comment please. Call me a docu-nazi, but I'd really love u- >> boot nicely and properly documented, please. >> > I'm all in favour of adding proper documentation, but I'm opposed to add > it in the middle of this cleanup/movement series. > > I'll send a patch on top of this series to add doc, so it doesn't > interfere with the review of this series. If the docs already exist and the function is simply changing its exact semantics, the docs should remain and simply be updated.