[U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port

Lucas Stach
2012-10-30T12:44:12Z

Hi Marek,

Am Dienstag, den 30.10.2012, 13:33 +0100 schrieb Marek Vasut:
> Dear Lucas Stach,
>
> [...]
>
> > > > -static int add_port(struct fdt_usb *config)
> > >
> > > Fix the comment instead of removing it?
> >
> > I don't think that this comment adds any real value. The whole function
> > which this comment refers to is removed and it's content split between
> > board_usb_init and ehci_hcd_init, which are self explanatory.
>
> Then add a proper comment please. Call me a docu-nazi, but I'd really love u-
> boot nicely and properly documented, please.
>
I'm all in favour of adding proper documentation, but I'm opposed to add
it in the middle of this cleanup/movement series.

I'll send a patch on top of this series to add doc, so it doesn't
interfere with the review of this series.

Regards,
Lucas