[U-Boot] [PATCH 7/8] tegra: usb: move implementation into right directory

Lucas Stach
2012-10-30T18:58:58Z

Am Dienstag, den 30.10.2012, 12:51 -0600 schrieb Stephen Warren:
> On 10/30/2012 12:45 PM, Lucas Stach wrote:
> > Am Dienstag, den 30.10.2012, 12:38 -0600 schrieb Stephen Warren:
> >> On 10/30/2012 03:22 AM, Lucas Stach wrote:
> >>> This moves the Tegra USB implementation into the drivers/usb/host
> >>> directory.
> >>
> >>> diff --git a/arch/arm/cpu/armv7/tegra20/usb.c b/drivers/usb/host/ehci-tegra.c
> >>
> >>> + * Copyright (c) 2009-2012 NVIDIA Corporation
> >>> * Copyright (c) 2011 The Chromium OS Authors.
> >>> - * (C) Copyright 2010,2011 NVIDIA Corporation <www.nvidia.com>
> >>
> >> Why does NVIDIA's (c) notice change?
> >>
> > Just because I took most of the licence header from the ehci_tegra.c
> > file, but as the patch shows the the diff modulo the copied part it
> > looks like a change. I choose this one as it actually spans the longer
> > copyright timeframe of the both licence headers. Is this a problem?
> > Should I also include the web address?
>
> Hmm. So this patch merges two files together into one? The diff looks
> like it's creating a new file. If the new content in this patch came
> from some other file, shouldn't the patch also remove it from the old
> file? That would make the (c) header change more obvious.
>
Hm, the rename presentation of this patch seems to cause major
confusion. Yes, this patch merges the Tegra usb implementation into the
pre-existing ehci_tegra.c file, which before this change did not much
more than to call into the Tegra SoC usb implementation. As the Tegra
usb implementation is not really SoC specific, but rather controller
specific this should really move over.

I will send this patch in the usual remove-add presentation for a V2 of
the series, as it even seems to confuse git right now.

Regards,
Lucas