[U-Boot] [PATCH] fs/fs.c: fix fs_set_blk_dev() for manual relocation

Tom Rini
2012-10-30T22:19:30Z

On Tue, Oct 30, 2012 at 12:41:02PM -0600, Stephen Warren wrote:
> On 10/30/2012 12:29 PM, Andreas Bie??mann wrote:
> > Commit 045fa1e1142552799ad3203e9e0bc22a11e866ea introduce an array with
> > filesystem accessors. On arches which need manual reloc this is broken cause the
> > function pointers still pointing to the privious location, fix it.
>
> We found the same code to copy:-)
>
> > diff --git a/fs/fs.c b/fs/fs.c
>
> > int fs_set_blk_dev(const char *ifname, const char *dev_part_str, int fstype)
>
> > +#ifdef CONFIG_NEEDS_MANUAL_RELOC
> > + static int relocated = 0;
>
> checkpatch bitches about the "= 0" there. I assume BSS initialization
> isn't also broken when CONFIG_NEEDS_MANUAL_RELOC is enabled?

The only other example of relocation this way also does an inital
assignment to 0. Andreas, can you run-time test? Thanks.

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121030/a40656d0/attachment.pgp>