public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 6/6] tegra: Enable NAND on Seaboard
Date: Thu, 01 Nov 2012 15:57:58 -0600	[thread overview]
Message-ID: <5092F066.2090307@wwwdotorg.org> (raw)
In-Reply-To: <1343631210-22278-7-git-send-email-sjg@chromium.org>

On 07/30/2012 12:53 AM, Simon Glass wrote:
> This enables NAND support for the Seaboard.

> diff --git a/include/configs/seaboard.h b/include/configs/seaboard.h

>  #include "tegra20-common-post.h"
>  
> +/* NAND support */
> +#define CONFIG_CMD_NAND
> +#define CONFIG_TEGRA_NAND
> +
> +/* Max number of NAND devices */
> +#define CONFIG_SYS_MAX_NAND_DEVICE	1
> +
> +/* Somewhat oddly, the NAND base address must be a config option */
> +#define CONFIG_SYS_NAND_BASE	TEGRA20_NAND_BASE

Simon, I just noticed that all these config options are added after the
include of tegra20-common-post.h. That file should be included at the
very end in case it needs to do something different based on the
board-specific configuration. I don't suppose you could move those lines
before the include?

  reply	other threads:[~2012-11-01 21:57 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30  6:53 [U-Boot] [PATCH v4 0/6] tegra: Add NAND flash support Simon Glass
2012-07-30  6:53 ` [U-Boot] [PATCH v4 1/6] nand: Try to align the default buffers Simon Glass
2012-07-30 22:45   ` Scott Wood
2012-09-07 18:20   ` Tom Warren
2012-09-07 18:43     ` Marek Vasut
2012-09-07 19:58       ` Tom Warren
2012-09-08  5:03         ` Marek Vasut
2012-07-30  6:53 ` [U-Boot] [PATCH v4 2/6] tegra: Add NAND support to funcmux Simon Glass
2012-07-30  6:53 ` [U-Boot] [PATCH v4 3/6] tegra: fdt: Add NAND controller binding and definitions Simon Glass
2012-07-30 23:05   ` Scott Wood
2012-07-31  9:19     ` Simon Glass
2012-07-30  6:53 ` [U-Boot] [PATCH v4 4/6] tegra: fdt: Add NAND definitions to fdt Simon Glass
2012-07-30 22:49   ` Scott Wood
2012-07-31  9:15     ` Simon Glass
2012-07-30  6:53 ` [U-Boot] [PATCH v4 5/6] tegra: nand: Add Tegra NAND driver Simon Glass
2012-07-30 22:32   ` Scott Wood
2012-07-30  6:53 ` [U-Boot] [PATCH v4 6/6] tegra: Enable NAND on Seaboard Simon Glass
2012-11-01 21:57   ` Stephen Warren [this message]
2012-11-01 23:13     ` Lucas Stach
2012-11-01 23:16       ` Simon Glass
2012-07-30 17:28 ` [U-Boot] [PATCH v4 0/6] tegra: Add NAND flash support Tom Warren
2012-07-30 17:34 ` Stephen Warren
2012-07-30 17:50   ` Tom Warren
2012-07-31  6:19 ` Thierry Reding
2012-09-07 21:31 ` Tom Warren
2012-09-07 21:33   ` Simon Glass
2012-09-21 21:44     ` Tom Warren
2012-09-21 21:57       ` Stephen Warren
2012-09-27 17:23         ` Simon Glass
2012-09-08  5:02   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5092F066.2090307@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox