From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: tegra: TrimSlice: add support for USB1 port
Date: Thu, 01 Nov 2012 17:30:40 -0600 [thread overview]
Message-ID: <50930620.9060100@wwwdotorg.org> (raw)
In-Reply-To: <1351811863.19243.5.camel@tellur>
On 11/01/2012 05:17 PM, Lucas Stach wrote:
> Hi Stephen,
>
> Am Donnerstag, den 01.11.2012, 16:14 -0600 schrieb Stephen Warren:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> TrimSlice's USB1 port has two purposes; it either acts as a device port
>> hosting Tegra's USB recovery protocol, or acts as a host port connected
>> to the internal USB->SATA bridge chip, which may in turn be connected to
>> an SSD or HDD. Add the appropriate device tree and board configuration
>> options to enable this port as a host port, and route the port to the
>> SATA bridge using the VBUS GPIO.
>>
> Hm, I don't really like to abuse the VBUS GPIO for this function. As the
> GPIO controlled routing is more a sort of pinmux can't you just add the
> GPIO enable to pin_mux_usb()?
I don't know, I think it's fine. It's certainly this way in the kernel.
And for all I know, this GPIO does actually affect VBUS as well as
flipping any mux (and the more I think about that, the more likely it
is) although I can't actually know for sure since I don't have the
schematics.
next prev parent reply other threads:[~2012-11-01 23:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 22:14 [U-Boot] [PATCH] ARM: tegra: TrimSlice: add support for USB1 port Stephen Warren
2012-11-01 23:17 ` Lucas Stach
2012-11-01 23:30 ` Stephen Warren [this message]
2012-11-01 23:34 ` Lucas Stach
2012-11-02 14:45 ` Stephen Warren
2012-11-02 15:30 ` Lucas Stach
2012-11-02 16:06 ` Stephen Warren
2012-11-02 2:14 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50930620.9060100@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox