From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Fri, 02 Nov 2012 08:45:30 -0600 Subject: [U-Boot] [PATCH] ARM: tegra: TrimSlice: add support for USB1 port In-Reply-To: <1351812849.19243.7.camel@tellur> References: <1351808077-11932-1-git-send-email-swarren@wwwdotorg.org> <1351811863.19243.5.camel@tellur> <50930620.9060100@wwwdotorg.org> <1351812849.19243.7.camel@tellur> Message-ID: <5093DC8A.1020507@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/01/2012 05:34 PM, Lucas Stach wrote: > Am Donnerstag, den 01.11.2012, 17:30 -0600 schrieb Stephen Warren: >> On 11/01/2012 05:17 PM, Lucas Stach wrote: >>> Hi Stephen, >>> >>> Am Donnerstag, den 01.11.2012, 16:14 -0600 schrieb Stephen Warren: >>>> From: Stephen Warren >>>> >>>> TrimSlice's USB1 port has two purposes; it either acts as a device port >>>> hosting Tegra's USB recovery protocol, or acts as a host port connected >>>> to the internal USB->SATA bridge chip, which may in turn be connected to >>>> an SSD or HDD. Add the appropriate device tree and board configuration >>>> options to enable this port as a host port, and route the port to the >>>> SATA bridge using the VBUS GPIO. >>>> >>> Hm, I don't really like to abuse the VBUS GPIO for this function. As the >>> GPIO controlled routing is more a sort of pinmux can't you just add the >>> GPIO enable to pin_mux_usb()? >> >> I don't know, I think it's fine. It's certainly this way in the kernel. >> And for all I know, this GPIO does actually affect VBUS as well as >> flipping any mux (and the more I think about that, the more likely it >> is) although I can't actually know for sure since I don't have the >> schematics. > > If it's really triggering VBUS I'm fine with this, but then the comment > in pin_mux_usb() is a bit off. Sorry, I don't see anything inaccurate about it. What's wrong?