* [U-Boot] [PATCH] sh: fix trigger_address_error()
@ 2012-11-05 1:53 Shimoda, Yoshihiro
2012-11-12 5:51 ` Nobuhiro Iwamatsu
0 siblings, 1 reply; 2+ messages in thread
From: Shimoda, Yoshihiro @ 2012-11-05 1:53 UTC (permalink / raw)
To: u-boot
The function should set BL bit, but it should not clear other flags.
So, the patch uses set_bl_bit() instead of a local asm code.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
arch/sh/include/asm/system.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/sh/include/asm/system.h b/arch/sh/include/asm/system.h
index 56fd77a..24b5ce8 100644
--- a/arch/sh/include/asm/system.h
+++ b/arch/sh/include/asm/system.h
@@ -274,8 +274,8 @@ void enable_hlt(void);
static inline void trigger_address_error(void)
{
+ set_bl_bit();
__asm__ __volatile__ (
- "ldc %0, sr\n\t"
"mov.l @%1, %0"
:
: "r" (0x10000000), "r" (0x80000001)
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [U-Boot] [PATCH] sh: fix trigger_address_error()
2012-11-05 1:53 [U-Boot] [PATCH] sh: fix trigger_address_error() Shimoda, Yoshihiro
@ 2012-11-12 5:51 ` Nobuhiro Iwamatsu
0 siblings, 0 replies; 2+ messages in thread
From: Nobuhiro Iwamatsu @ 2012-11-12 5:51 UTC (permalink / raw)
To: u-boot
Applied, thanks.
Best regards,
Nobuhiro
On Mon, Nov 5, 2012 at 10:53 AM, Shimoda, Yoshihiro
<yoshihiro.shimoda.uh@renesas.com> wrote:
> The function should set BL bit, but it should not clear other flags.
> So, the patch uses set_bl_bit() instead of a local asm code.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> arch/sh/include/asm/system.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/sh/include/asm/system.h b/arch/sh/include/asm/system.h
> index 56fd77a..24b5ce8 100644
> --- a/arch/sh/include/asm/system.h
> +++ b/arch/sh/include/asm/system.h
> @@ -274,8 +274,8 @@ void enable_hlt(void);
>
> static inline void trigger_address_error(void)
> {
> + set_bl_bit();
> __asm__ __volatile__ (
> - "ldc %0, sr\n\t"
> "mov.l @%1, %0"
> :
> : "r" (0x10000000), "r" (0x80000001)
> --
> 1.7.1
--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-12 5:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-05 1:53 [U-Boot] [PATCH] sh: fix trigger_address_error() Shimoda, Yoshihiro
2012-11-12 5:51 ` Nobuhiro Iwamatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox