u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V1 5/5] imximage.cfg: run files through C preprocessor
Date: Sat, 10 Nov 2012 08:23:49 +0100	[thread overview]
Message-ID: <509E0105.1060508@denx.de> (raw)
In-Reply-To: <1351025870-14394-6-git-send-email-troy.kisky@boundarydevices.com>

On 23/10/2012 22:57, Troy Kisky wrote:
> The '#' used as comments in the files cause the preprocessor
> trouble, so change to /* */.
> 
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> ---


Hi Troy,

>  .gitignore                                   |    1 +
>  Makefile                                     |   11 +-
>  board/esg/ima3-mx53/imximage.cfg             |  120 ++++++-----
>  board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg |   90 ++++----
>  board/freescale/mx25pdk/imximage.cfg         |   77 +++----
>  board/freescale/mx51evk/imximage.cfg         |  114 +++++-----
>  board/freescale/mx53ard/imximage_dd3.cfg     |   83 ++++----
>  board/freescale/mx53evk/imximage.cfg         |   86 ++++----
>  board/freescale/mx53loco/imximage.cfg        |   83 ++++----
>  board/freescale/mx53smd/imximage.cfg         |   83 ++++----
>  board/freescale/mx6qarm2/imximage.cfg        |   88 ++++----
>  board/freescale/mx6qsabreauto/imximage.cfg   |   82 +++----
>  board/genesi/mx51_efikamx/imximage_mx.cfg    |  132 ++++++------
>  board/genesi/mx51_efikamx/imximage_sb.cfg    |  126 +++++------
>  board/ttcontrol/vision2/imximage_hynix.cfg   |  295 ++++++++++++++------------
>  15 files changed, 777 insertions(+), 694 deletions(-)
> 

I am not sure. I see that Tom agree using /* comment style, but I have
not seen a general agreement where to move the rule (in which Makefile,
I mean). Tom, is it ok for you to add the rule in the main Makefile ?

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2012-11-10  7:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-23 20:57 [U-Boot] [PATCH V1 0/5] prepare for mx6dl/ mx6solo Troy Kisky
2012-10-23 20:57 ` [U-Boot] [PATCH V1 1/5] mx6: soc: update get_cpu_rev and get_imx_type for mx6solo/sololite Troy Kisky
2012-11-10  7:18   ` Stefano Babic
2012-10-23 20:57 ` [U-Boot] [PATCH V1 2/5] mx6: use CONFIG_MX6 instead of CONFIG_MX6Q Troy Kisky
2012-11-10  7:17   ` Stefano Babic
2012-10-23 20:57 ` [U-Boot] [PATCH V1 3/5] imx-common: cpu: add imx_ddr_size Troy Kisky
2012-11-10  7:17   ` Stefano Babic
2012-10-23 20:57 ` [U-Boot] [PATCH V1 4/5] arch-mx6: add mx6dl_pins.h Troy Kisky
2012-11-10  7:18   ` Stefano Babic
2012-10-23 20:57 ` [U-Boot] [PATCH V1 5/5] imximage.cfg: run files through C preprocessor Troy Kisky
2012-11-10  7:23   ` Stefano Babic [this message]
2013-01-18  1:49   ` [U-Boot] [PATCH V2 1/1] " Troy Kisky
2013-01-18  8:06     ` Albert ARIBAUD
2013-01-19  2:14     ` [U-Boot] [PATCH V3 " Troy Kisky
2013-01-23 10:05       ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509E0105.1060508@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).