From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hayes Wang Date: Wed, 10 Jun 2020 09:47:53 +0000 Subject: [PATCH u-boot 2/4] eth/r8152: reset PHY after setting it In-Reply-To: References: <1394712342-15778-377-Taiwan-albertk@realtek.com> <1394712342-15778-379-Taiwan-albertk@realtek.com> Message-ID: <509ebf533a804b2098f2265ec51e0dfa@realtek.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Marek Vasut [mailto:marex at denx.de] > Sent: Tuesday, June 09, 2020 10:22 PM [...] > > - bmcr = BMCR_ANENABLE | BMCR_ANRESTART; > > + bmcr = BMCR_ANENABLE | BMCR_ANRESTART | BMCR_RESET; > > Do you really need to reset a PHY while resetting the autonegotiation ? > I think if you reset the PHY , then the ANEG operation is restarted by > default or undefined, no ? The setting is from the HW engineer. And I follow the rule for a long time. I think they know what they do. Best Regards, Hayes