public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] omap4: Add comments on some "#endif"s for readability.
@ 2012-11-13 18:12 Robert P. J. Day
  2012-11-14 13:16 ` R Sricharan
  2012-12-10 20:16 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Robert P. J. Day @ 2012-11-13 18:12 UTC (permalink / raw)
  To: u-boot


No functional changes, simply for readability.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

diff --git a/arch/arm/cpu/armv7/omap4/clocks.c b/arch/arm/cpu/armv7/omap4/clocks.c
index 5bd0a88..12c5803 100644
--- a/arch/arm/cpu/armv7/omap4/clocks.c
+++ b/arch/arm/cpu/armv7/omap4/clocks.c
@@ -44,7 +44,7 @@
  */
 #define printf(fmt, args...)
 #define puts(s)
-#endif
+#endif /* !CONFIG_SPL_BUILD */

 struct omap4_prcm_regs *const prcm = (struct omap4_prcm_regs *)0x4A004100;

diff --git a/arch/arm/cpu/armv7/omap4/hwinit.c b/arch/arm/cpu/armv7/omap4/hwinit.c
index 2c34e48..f4123aa 100644
--- a/arch/arm/cpu/armv7/omap4/hwinit.c
+++ b/arch/arm/cpu/armv7/omap4/hwinit.c
@@ -116,7 +116,7 @@ void do_io_settings(void)
 	if ((omap4_rev < OMAP4460_ES1_0) || !readl(&ctrl->control_efuse_2))
 		writel(CONTROL_EFUSE_2_OVERRIDE, &ctrl->control_efuse_2);
 }
-#endif
+#endif /* CONFIG_SPL_BUILD */

 /* dummy fuction for omap4 */
 void config_data_eye_leveling_samples(u32 emif_base)
@@ -182,4 +182,4 @@ void v7_outer_cache_disable(void)
 {
 	set_pl310_ctrl_reg(0);
 }
-#endif
+#endif /* !CONFIG_SYS_L2CACHE_OFF */


-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] omap4: Add comments on some "#endif"s for readability.
  2012-11-13 18:12 [U-Boot] [PATCH] omap4: Add comments on some "#endif"s for readability Robert P. J. Day
@ 2012-11-14 13:16 ` R Sricharan
  2012-12-10 20:16 ` [U-Boot] " Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: R Sricharan @ 2012-11-14 13:16 UTC (permalink / raw)
  To: u-boot

On Tuesday 13 November 2012 11:42 PM, Robert P. J. Day wrote:
>
> No functional changes, simply for readability.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> diff --git a/arch/arm/cpu/armv7/omap4/clocks.c b/arch/arm/cpu/armv7/omap4/clocks.c
> index 5bd0a88..12c5803 100644
> --- a/arch/arm/cpu/armv7/omap4/clocks.c
> +++ b/arch/arm/cpu/armv7/omap4/clocks.c
> @@ -44,7 +44,7 @@
>    */
>   #define printf(fmt, args...)
>   #define puts(s)
> -#endif
> +#endif /* !CONFIG_SPL_BUILD */
>
>   struct omap4_prcm_regs *const prcm = (struct omap4_prcm_regs *)0x4A004100;
>
> diff --git a/arch/arm/cpu/armv7/omap4/hwinit.c b/arch/arm/cpu/armv7/omap4/hwinit.c
> index 2c34e48..f4123aa 100644
> --- a/arch/arm/cpu/armv7/omap4/hwinit.c
> +++ b/arch/arm/cpu/armv7/omap4/hwinit.c
> @@ -116,7 +116,7 @@ void do_io_settings(void)
>   	if ((omap4_rev < OMAP4460_ES1_0) || !readl(&ctrl->control_efuse_2))
>   		writel(CONTROL_EFUSE_2_OVERRIDE, &ctrl->control_efuse_2);
>   }
> -#endif
> +#endif /* CONFIG_SPL_BUILD */
>
>   /* dummy fuction for omap4 */
>   void config_data_eye_leveling_samples(u32 emif_base)
> @@ -182,4 +182,4 @@ void v7_outer_cache_disable(void)
>   {
>   	set_pl310_ctrl_reg(0);
>   }
> -#endif
> +#endif /* !CONFIG_SYS_L2CACHE_OFF */
>
>

  Thanks..

Regards,
  Sricharan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] omap4: Add comments on some "#endif"s for readability.
  2012-11-13 18:12 [U-Boot] [PATCH] omap4: Add comments on some "#endif"s for readability Robert P. J. Day
  2012-11-14 13:16 ` R Sricharan
@ 2012-12-10 20:16 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2012-12-10 20:16 UTC (permalink / raw)
  To: u-boot

On Tue, Nov 13, 2012 at 08:12:08AM -0000, Robert P. J. Day wrote:

> No functional changes, simply for readability.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

Applied to u-boot-ti/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121210/dc5a4174/attachment.pgp>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-12-10 20:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-13 18:12 [U-Boot] [PATCH] omap4: Add comments on some "#endif"s for readability Robert P. J. Day
2012-11-14 13:16 ` R Sricharan
2012-12-10 20:16 ` [U-Boot] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox