public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] mx5: Print CSPI clock in 'clock' command
Date: Fri, 16 Nov 2012 14:18:45 +0100	[thread overview]
Message-ID: <50A63D35.3060009@denx.de> (raw)
In-Reply-To: <CAOMZO5C-m0Ly_mAkm9MZe311g02P-UofhHS3_P47Fzr0Jip+Hw@mail.gmail.com>

On 16/11/2012 12:15, Fabio Estevam wrote:
> Hi Dirk,
> 
> On Fri, Nov 16, 2012 at 4:35 AM, Dirk Behme <dirk.behme@gmail.com> wrote:
> 
>> I wondered if we want something similar for i.MX6, too. And found that we
>> have this on i.MX6, already. But without #ifdef.
>>
>> http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=blob;f=arch/arm/cpu/armv7/mx6/clock.c;h=a01d96f48e04377d705b7a587ec7b3ea59aee283;hb=HEAD#l407
>>
>> Do we want to add the #ifdef for i.MX6, too? Or would it be nicer to drop
>> the #ifdef in this patch to make i.MX6 and i.MX5 equal?
> 
> The reason I added the ifdef was to avoid showing the cspi clock on a
> board that does not use cspi. This would help
> not 'polluting' the clock command output.
> 

Agree. Boards that do not support SPI can have a completely wrong value,.

Regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2012-11-16 13:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 21:23 [U-Boot] [PATCH 1/4] mx5: Align SPI CS naming with i.MX53 reference manual Fabio Estevam
2012-11-15 21:23 ` [U-Boot] [PATCH 2/4] mx5: Print CSPI clock in 'clock' command Fabio Estevam
2012-11-16  6:35   ` Dirk Behme
2012-11-16 11:15     ` Fabio Estevam
2012-11-16 13:18       ` Stefano Babic [this message]
2012-11-15 21:23 ` [U-Boot] [PATCH 3/4] spi: mxc_spi: Fix handling of chip select Fabio Estevam
2012-11-15 21:23 ` [U-Boot] [PATCH 4/4] spi: mxc_spi: Fix spi clock glitch durant reset Fabio Estevam
2012-11-16 13:17   ` Stefano Babic
2012-11-19  7:51 ` [U-Boot] [PATCH 1/4] mx5: Align SPI CS naming with i.MX53 reference manual Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A63D35.3060009@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox