From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Custodian branch base commits
Date: Sat, 17 Nov 2012 20:57:33 -0500 [thread overview]
Message-ID: <50A8408D.9060901@gmail.com> (raw)
In-Reply-To: <509052C2.2090203@wwwdotorg.org>
On 10/30/2012 06:20 PM, Stephen Warren wrote:
> On 10/30/2012 04:06 PM, Wolfgang Denk wrote:
>> Dear Stephen Warren,
>>
>> In message <5090423C.5070605@wwwdotorg.org> you wrote:
>>>
>>>>>>> git checkout master
>>>>>>> git reset --hard u-boot/master
>> ...
>>>> Why don't you do just
>>>> git branch -D master
>>>> git checkout -b master u-boot/master
>>>> instead?
>>>
>>> That would work identically. The exact git commands to do this really
>>> aren't the point of this conversation.
>>
>> Maybe not for you. But I was trying to understand what you are doing,
>> and I find your approach difficult to read. A "git reset --hard" is
>> nothign I ever do in the normal course of actions.
>>
>>>> BTW - why are you doing this on the "master" branch? Any other branch
>>>> name appears more appropriate to me for such work?
>>>
>>> Well, the U-Boot wiki tells all custodians to use a branch named master,
>>> and all the custodian repos I've needed to look at follow this convention.
>>
>> You are supposed to _never_ reset or rebase the master branch.
>
> I assume that statement is conditionalized by "within the U-Boot
> process" and "in the main u-boot.git repository"; it's not necessarily
> required to be true just due to use of git.
>
> Well, even in recent history, that hasn't been actual practice. The wiki
> even explicitly tells you to rebase:
>
> http://www.denx.de/wiki/U-Boot/CustodianGitTrees
>
> Who owns updating that?
It's a wiki, *nobody* owns it. :-O
> I could take a stab, but since I'm pretty new to U-Boot development,
> not a custodian, and pushing for changes, I'm probably not the best
> person to re-write it, and least not without a
> code-review/patch-based process.
I wrote the advice in 2007, relatively early days in our (u-boot's and
my) git usage.
<http://www.denx.de/wiki/view/U-Boot/CustodianGitTrees?rev=1.19>
It is definitely worth updating to recommend better techniques.
Best regards,
gvb
[snip]
next prev parent reply other threads:[~2012-11-18 1:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 17:35 [U-Boot] Custodian branch base commits Stephen Warren
2012-10-30 18:50 ` Wolfgang Denk
2012-10-30 18:55 ` Stephen Warren
2012-10-30 20:47 ` Wolfgang Denk
2012-10-30 21:10 ` Stephen Warren
2012-10-30 22:06 ` Wolfgang Denk
2012-10-30 22:20 ` Stephen Warren
2012-11-18 1:57 ` Jerry Van Baren [this message]
2012-10-30 21:19 ` Tom Rini
2012-10-31 16:56 ` Stephen Warren
2012-11-03 11:49 ` Albert ARIBAUD
2012-11-05 17:17 ` Stephen Warren
2012-11-05 19:39 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A8408D.9060901@gmail.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox