From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ehci-mxc: Fix host power mask bit for i.MX35
Date: Mon, 19 Nov 2012 08:53:18 +0100 [thread overview]
Message-ID: <50A9E56E.9000700@denx.de> (raw)
In-Reply-To: <1605362053.1460917.1353066169872.JavaMail.root@advansee.com>
On 16/11/2012 12:42, Beno?t Th?baudeau wrote:
> The correct bit for H1_PM is 16, not 8, which is the DP pull-up impedance
> selection bit.
>
> This issue has been reported by Michael Burkey <mdburkey@gmail.com> and fixed by
> Christoph Fritz <chf.fritz@googlemail.com> on Linux, from which these #define-s
> had been copied.
>
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> ---
> .../drivers/usb/host/ehci-mxc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git u-boot-imx-f22e4fa.orig/drivers/usb/host/ehci-mxc.c u-boot-imx-f22e4fa/drivers/usb/host/ehci-mxc.c
> index 7c5f71c..f2642a0 100644
> --- u-boot-imx-f22e4fa.orig/drivers/usb/host/ehci-mxc.c
> +++ u-boot-imx-f22e4fa/drivers/usb/host/ehci-mxc.c
> @@ -67,7 +67,7 @@
> #define MX35_H1_SIC_SHIFT 21
> #define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT)
> #define MX35_H1_PP_BIT (1 << 18)
> -#define MX35_H1_PM_BIT (1 << 8)
> +#define MX35_H1_PM_BIT (1 << 16)
> #define MX35_H1_IPPUE_UP_BIT (1 << 7)
> #define MX35_H1_IPPUE_DOWN_BIT (1 << 6)
> #define MX35_H1_TLL_BIT (1 << 5)
>
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2012-11-19 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 11:42 [U-Boot] [PATCH] ehci-mxc: Fix host power mask bit for i.MX35 Benoît Thébaudeau
2012-11-16 13:12 ` Stefano Babic
2012-11-19 7:53 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A9E56E.9000700@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox