[U-Boot] [PATCH 06/22] ARM sunxi: Basic GPIO driver

Henrik Nordström
2012-11-25T23:41:22Z

s?n 2012-11-25 klockan 20:50 +0100 skrev Wolfgang Denk:
> Dear Henrik Nordstr?m,
>
> In message <1353843623.17518.17.camel@home.hno.se> you wrote:
> > GPIO driver for Allwinner sun4i/sun5i family of SoCs
> >
> > GPIO Pins are named by their symbolic pin names P<g><#>
> > such as PH19 or H19.
> >
> > Note: This do not perform any validation if the pin is in use
> > for some other I/O function. Use with care.
>
> SoB missing.

Sorry about that.

> Um.... are these patches actually bisectable??? It appears not; for
> example, you reference gpio_direction_input() in ealier patches, but
> define it only now.

Um.. right, on sun4i_sdcon with console redirected to the SD pins the
uart code uses that as a shorthand for sunxi_gpio_set_cfgpin(). Fixing.
Thanks for noticing.

And sorry for not doing a full matrix bisect validation, only did bisect
test on the basic targets when splitting the patch series. Will run a
full bisect matrix test for next round.

Regards
Henrik