[U-Boot] [PATCH 01/22] ARM: sunxi: Basic Allwinner A10/A13 (sun4i/sun5i) support

Henrik Nordström
2012-11-25T13:08:59Z

s?n 2012-11-25 klockan 13:23 +0100 skrev Luka Perkov:
> Hi Henrik,
>
> I have few comments bellow.
>
> > +++ b/arch/arm/cpu/armv7/sunxi/Makefile

> > +# (C) Copyright 2000-2003
>
> I don't know about the dates. It's 2012 now... Same goes for all other files.

Heh.. Not sure which board that was copied from.

Not sure what to set as copyright here. Can't say there have been any
significant contributions by anyone in this file, but have updated the
year to 2011-2012 to match current use.

Reviewing the others to see if copyright should be bumped, but some are
really published in 2011 and have only received non-copyrightable
cleanups after.

There is some doubt on the earlier span of the copyright on Allwinner
code, quite likely many are originally from 2011 and not 2007-2011 as
their copyright template says, but not in a position to tell for sure.

> > +#define CONFIG_SUNXI /* which is sunxi family */
>
> Space, not tab here.

Fixed.

> > +/* Clock Defines */
>
> Why not remove this comment when there is no defines under it ?

Removed.

> > +/*-----------------------------------------------------------------------
>
> I don't think we need "----" chars above.

Fixed.

> > +/*-----------------------------------------------------------------------
>
> I don't think we need "----" chars above.

Fixed.

> > +#define CONFIG_IDENT_STRING " Allwinner Technology "
>
> Why do you need trailing space ?

We don't. Fixed.

Revised patch coming shortly.

Regards
Henrik