[U-Boot] [PATCH 02/22] ARM: sunxi: MMC driver

Luka Perkov
2012-11-25T14:33:32Z

On Sun, Nov 25, 2012 at 12:37:59PM +0100, Henrik Nordstr?m wrote:
> This adds a basic MMC driver for Allwinner sun4i/sun5i family of SoC
> this driver is limited to a single MMC channel.
>
> Signed-off-by: Tom Cubie <tangliang@allwinnertech.com>
> Signed-off-by: Henrik Nodstrom <henrik@henriknordstrom.net>
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
> arch/arm/include/asm/arch-sunxi/mmc.h | 64 +++
> board/sunxi/board.c | 9 +
> drivers/mmc/Makefile | 1 +
> drivers/mmc/sunxi_mmc.c | 674 +++++++++++++++++++++++++++++++++
> include/configs/sunxi-common.h | 14 +-
> 5 files changed, 759 insertions(+), 3 deletions(-)
> create mode 100644 arch/arm/include/asm/arch-sunxi/mmc.h
> create mode 100644 drivers/mmc/sunxi_mmc.c
>
> diff --git a/arch/arm/include/asm/arch-sunxi/mmc.h b/arch/arm/include/asm/arch-sunxi/mmc.h
> new file mode 100644
> index 0000000..e96e7d2
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-sunxi/mmc.h
> @@ -0,0 +1,64 @@
> +/*
> + * (C) Copyright 2007-2011
> + * Allwinner Technology Co., Ltd. <www.allwinnertech.com>
> + * Aaron <leafy.myeh@allwinnertech.com>
> + *
> + * MMC register definition for allwinner sunxi platform.
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#ifndef _SUNXI_MMC_H
> +#define _SUNXI_MMC_H
> +
> +struct sunxi_mmc {
> + u32 gctrl; /* (0x00) SMC Global Control Register */
> + u32 clkcr; /* (0x04) SMC Clock Control Register */
> + u32 timeout; /* (0x08) SMC Time Out Register */
> + u32 width; /* (0x0C) SMC Bus Width Register */
> + u32 blksz; /* (0x10) SMC Block Size Register */
> + u32 bytecnt; /* (0x14) SMC Byte Count Register */
> + u32 cmd; /* (0x18) SMC Command Register */
> + u32 arg; /* (0x1C) SMC Argument Register */
> + u32 resp0; /* (0x20) SMC Response Register 0 */
> + u32 resp1; /* (0x24) SMC Response Register 1 */
> + u32 resp2; /* (0x28) SMC Response Register 2 */
> + u32 resp3; /* (0x2C) SMC Response Register 3 */
> + u32 imask; /* (0x30) SMC Interrupt Mask Register */
> + u32 mint; /* (0x34) SMC Masked Interrupt Status Reg */
> + u32 rint; /* (0x38) SMC Raw Interrupt Status Register */
> + u32 status; /* (0x3C) SMC Status Register */
> + u32 ftrglevel; /* (0x40) SMC FIFO Threshold Watermark Reg */
> + u32 funcsel; /* (0x44) SMC Function Select Register */
> + u32 cbcr; /* (0x48) SMC CIU Byte Count Register */
> + u32 bbcr; /* (0x4C) SMC BIU Byte Count Register */
> + u32 dbgc; /* (0x50) SMC Debug Enable Register */
> + u32 res0[11]; /* (0x54~0x7c) */
> + u32 dmac; /* (0x80) SMC IDMAC Control Register */
> + u32 dlba; /* (0x84) SMC IDMAC Descr List Base Addr Reg */
> + u32 idst; /* (0x88) SMC IDMAC Status Register */
> + u32 idie; /* (0x8C) SMC IDMAC Interrupt Enable Register */
> + u32 chda; /* (0x90) */
> + u32 cbda; /* (0x94) */
> + u32 res1[26]; /* (0x98~0xff) */
> + u32 fifo; /* (0x100) SMC FIFO Access Address */
> +};
> +
> +int sunxi_mmc_init(int sdc_no);
> +#endif /* _SUNXI_MMC_H */
> diff --git a/board/sunxi/board.c b/board/sunxi/board.c
> index ae05953..50fb40f 100644
> --- a/board/sunxi/board.c
> +++ b/board/sunxi/board.c
> @@ -55,3 +55,12 @@ int dram_init(void)
>
> return 0;
> }
> +
> +#ifdef CONFIG_GENERIC_MMC
> +int board_mmc_init(bd_t *bis)
> +{
> + sunxi_mmc_init(CONFIG_MMC_SUNXI_SLOT);
> +
> + return 0;
> +}
> +#endif
> diff --git a/drivers/mmc/Makefile b/drivers/mmc/Makefile
> index a1dd730..6128910 100644
> --- a/drivers/mmc/Makefile
> +++ b/drivers/mmc/Makefile
> @@ -47,6 +47,7 @@ COBJS-$(CONFIG_S5P_SDHCI) += s5p_sdhci.o
> COBJS-$(CONFIG_SH_MMCIF) += sh_mmcif.o
> COBJS-$(CONFIG_TEGRA_MMC) += tegra_mmc.o
> COBJS-$(CONFIG_DWMMC) += dw_mmc.o
> +COBJS-$(CONFIG_MMC_SUNXI) += sunxi_mmc.o
>
> COBJS := $(COBJS-y)
> SRCS := $(COBJS:.o=.c)
> diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
> new file mode 100644
> index 0000000..05bc231
> --- /dev/null
> +++ b/drivers/mmc/sunxi_mmc.c
> @@ -0,0 +1,674 @@
> +/*
> + * (C) Copyright 2007-2011
> + * Allwinner Technology Co., Ltd. <www.allwinnertech.com>
> + * Aaron <leafy.myeh@allwinnertech.com>
> + *
> + * MMC driver for allwinner sunxi platform.
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <common.h>
> +#include <asm/io.h>
> +#include <asm/arch/cpu.h>
> +#include <asm/arch/clock.h>
> +#include <asm/arch/gpio.h>
> +#include <asm/arch/mmc.h>
> +#include <malloc.h>
> +#include <mmc.h>
> +
> +#undef SUNXI_MMCDBG
> +
> +#ifdef SUNXI_MMCDBG
> +#define MMCDBG(fmt...) printf("[mmc]: "fmt)

Why not reuse something from existing uboot code ? (exaple from api/api.c):

36 #define DEBUG
37 #undef DEBUG

...

53 #ifdef DEBUG
54 #define debugf(fmt, args...) do { printf("%s(): ", __func__); printf(fmt, ##args); } while (0)
55 #else
56 #define debugf(fmt, args...)
57 #endif

> +
> +static void dumphex32(char *name, char *base, int len)
> +{
> + __u32 i;
> +
> + printf("dump %s registers:", name);
> + for (i = 0; i < len; i += 4) {
> + if (!(i & 0xf))
> + printf("\n0x%p : ", base + i);
> + printf("0x%08x ", readl(base + i));
> + }
> + printf("\n");
> +}
> +
> +static void dumpmmcreg(struct sunxi_mmc *reg)
> +{

I dont see this function is called anywhere...

> + printf("dump mmc registers:\n");
> + printf("gctrl 0x%08x\n", reg->gctrl);
> + printf("clkcr 0x%08x\n", reg->clkcr);
> + printf("timeout 0x%08x\n", reg->timeout);
> + printf("width 0x%08x\n", reg->width);
> + printf("blksz 0x%08x\n", reg->blksz);
> + printf("bytecnt 0x%08x\n", reg->bytecnt);
> + printf("cmd 0x%08x\n", reg->cmd);
> + printf("arg 0x%08x\n", reg->arg);
> + printf("resp0 0x%08x\n", reg->resp0);
> + printf("resp1 0x%08x\n", reg->resp1);
> + printf("resp2 0x%08x\n", reg->resp2);
> + printf("resp3 0x%08x\n", reg->resp3);
> + printf("imask 0x%08x\n", reg->imask);
> + printf("mint 0x%08x\n", reg->mint);
> + printf("rint 0x%08x\n", reg->rint);
> + printf("status 0x%08x\n", reg->status);
> + printf("ftrglevel 0x%08x\n", reg->ftrglevel);
> + printf("funcsel 0x%08x\n", reg->funcsel);
> + printf("dmac 0x%08x\n", reg->dmac);
> + printf("dlba 0x%08x\n", reg->dlba);
> + printf("idst 0x%08x\n", reg->idst);
> + printf("idie 0x%08x\n", reg->idie);
> +}
> +#else
> +#define MMCDBG(fmt...)
> +#define dumphex32(fmt...)
> +#define dumpmmcreg(fmt...)
> +#endif /* SUNXI_MMCDBG */
> +
> +struct sunxi_mmc_des {
> + u32 reserved1_1:1;
> + u32 dic:1; /* disable interrupt on completion */
> + u32 last_des:1; /* 1-this data buffer is the last buffer */
> + u32 first_des:1; /* 1-data buffer is the first buffer,
> + 0-data buffer contained in the next
> + descriptor is 1st buffer */
> + u32 des_chain:1; /* 1-the 2nd address in the descriptor is the
> + next descriptor address */
> + u32 end_of_ring:1; /* 1-last descriptor flag when using dual
> + data buffer in descriptor */
> + u32 reserved1_2:24;
> + u32 card_err_sum:1; /* transfer error flag */
> + u32 own:1; /* des owner:1-idma owns it, 0-host owns it */
> +#if defined CONFIG_SUN4I
> +#define SDXC_DES_NUM_SHIFT 13
> +#define SDXC_DES_BUFFER_MAX_LEN (1 << SDXC_DES_NUM_SHIFT)
> + u32 data_buf1_sz:13;
> + u32 data_buf2_sz:13;
> + u32 reserverd2_1:6;
> +#elif defined CONFIG_SUN5I
> +#define SDXC_DES_NUM_SHIFT 16
> +#define SDXC_DES_BUFFER_MAX_LEN (1 << SDXC_DES_NUM_SHIFT)
> + u32 data_buf1_sz:16;
> + u32 data_buf2_sz:16;
> +#else
> +#error ">>>> Wrong Platform for MMC <<<<"
> +#endif
> + u32 buf_addr_ptr1;
> + u32 buf_addr_ptr2;
> +};
> +
> +struct sunxi_mmc_host {
> + unsigned mmc_no;
> + uint32_t *mclkreg;
> + unsigned database;
> + unsigned fatal_err;
> + unsigned mod_clk;
> + struct sunxi_mmc *reg;
> + struct sunxi_mmc_des *pdes;
> +};
> +
> +/* support 4 mmc hosts */
> +struct mmc mmc_dev[4];
> +struct sunxi_mmc_host mmc_host[4];
> +
> +static int mmc_resource_init(int sdc_no)
> +{
> + struct sunxi_mmc_host *mmchost = &mmc_host[sdc_no];
> + struct sunxi_ccm_reg *ccm = (struct sunxi_ccm_reg *)SUNXI_CCM_BASE;
> +
> + MMCDBG("init mmc %d resource\n", sdc_no);
> +
> + switch (sdc_no) {
> + case 0:
> + mmchost->reg = (struct sunxi_mmc *)SUNXI_MMC0_BASE;
> + mmchost->mclkreg = &ccm->sd0_clk_cfg;
> + break;
> + case 1:
> + mmchost->reg = (struct sunxi_mmc *)SUNXI_MMC1_BASE;
> + mmchost->mclkreg = &ccm->sd1_clk_cfg;
> + break;
> + case 2:
> + mmchost->reg = (struct sunxi_mmc *)SUNXI_MMC2_BASE;
> + mmchost->mclkreg = &ccm->sd2_clk_cfg;
> + break;
> + case 3:
> + mmchost->reg = (struct sunxi_mmc *)SUNXI_MMC3_BASE;
> + mmchost->mclkreg = &ccm->sd3_clk_cfg;
> + break;
> + default:
> + printf("Wrong mmc number %d\n", sdc_no);
> + return -1;
> + }
> + mmchost->database = (unsigned int)mmchost->reg + 0x100;
> + mmchost->mmc_no = sdc_no;
> +
> + return 0;
> +}
> +
> +static int mmc_clk_io_on(int sdc_no)
> +{
> + unsigned int rval;
> + unsigned int pll5_clk;
> + unsigned int divider;
> + struct sunxi_mmc_host *mmchost = &mmc_host[sdc_no];
> + static struct sunxi_gpio *gpio_c =
> + &((struct sunxi_gpio_reg *)SUNXI_PIO_BASE)->gpio_bank[SUNXI_GPIO_C];
> + static struct sunxi_gpio *gpio_f =
> + &((struct sunxi_gpio_reg *)SUNXI_PIO_BASE)->gpio_bank[SUNXI_GPIO_F];
> +#if CONFIG_MMC1_PG
> + static struct sunxi_gpio *gpio_g =
> + &((struct sunxi_gpio_reg *)SUNXI_PIO_BASE)->gpio_bank[SUNXI_GPIO_G];
> +#endif
> + static struct sunxi_gpio *gpio_h =
> + &((struct sunxi_gpio_reg *)SUNXI_PIO_BASE)->gpio_bank[SUNXI_GPIO_H];
> + static struct sunxi_gpio *gpio_i =
> + &((struct sunxi_gpio_reg *)SUNXI_PIO_BASE)->gpio_bank[SUNXI_GPIO_I];
> + struct sunxi_ccm_reg *ccm = (struct sunxi_ccm_reg *)SUNXI_CCM_BASE;
> +
> + MMCDBG("init mmc %d clock and io\n", sdc_no);
> +
> + /* config gpio */
> + switch (sdc_no) {
> + case 0:
> + /* D1-PF0, D0-PF1, CLK-PF2, CMD-PF3, D3-PF4, D4-PF5 */
> + writel(0x222222, &gpio_f->cfg[0]);
> + writel(0x555, &gpio_f->pull[0]);
> + writel(0xaaa, &gpio_f->drv[0]);
> + break;
> +
> + case 1:
> +#if CONFIG_MMC1_PG
> + /* PG0-CMD, PG1-CLK, PG2~5-D0~3 : 4 */
> + writel(0x444444, &gpio_g->cfg[0]);
> + writel(0x555, &gpio_g->pull[0]);
> + writel(0xaaa, &gpio_g->drv[0]);
> +#else
> + /* PH22-CMD, PH23-CLK, PH24~27-D0~D3 : 5 */
> + writel(0x55 << 24, &gpio_h->cfg[2]);
> + writel(0x5555, &gpio_h->cfg[3]);
> + writel(0x555 << 12, &gpio_h->pull[1]);
> + writel(0xaaa << 12, &gpio_h->drv[1]);
> +#endif
> + break;
> +
> + case 2:
> + /* CMD-PC6, CLK-PC7, D0-PC8, D1-PC9, D2-PC10, D3-PC11 */
> + writel(0x33 << 24, &gpio_c->cfg[0]);
> + writel(0x3333, &gpio_c->cfg[1]);
> + writel(0x555 << 12, &gpio_c->pull[0]);
> + writel(0xaaa << 12, &gpio_c->drv[0]);
> + break;
> +
> + case 3:
> + /* PI4-CMD, PI5-CLK, PI6~9-D0~D3 : 2 */
> + writel(0x2222 << 16, &gpio_i->cfg[0]);
> + writel(0x22, &gpio_i->cfg[1]);
> + writel(0x555 << 8, &gpio_i->pull[0]);
> + writel(0x555 << 8, &gpio_i->drv[0]);
> + break;
> +
> + default:
> + return -1;
> + }
> +
> + /* config ahb clock */
> + rval = readl(&ccm->ahb_gate0);
> + rval |= (1 << (8 + sdc_no));
> + writel(rval, &ccm->ahb_gate0);
> +
> + /* config mod clock */
> + pll5_clk = clock_get_pll5();
> + if (pll5_clk > 400000000)
> + divider = 4;
> + else
> + divider = 3;
> + writel((1U << 31) | (2U << 24) | divider, mmchost->mclkreg);
> + mmchost->mod_clk = pll5_clk / (divider + 1);
> +
> + dumphex32("ccmu", (char *)SUNXI_CCM_BASE, 0x100);
> + dumphex32("gpio", (char *)SUNXI_PIO_BASE, 0x100);
> + dumphex32("mmc", (char *)mmchost->reg, 0x100);
> +
> + return 0;
> +}
> +
> +static int mmc_update_clk(struct mmc *mmc)
> +{
> + struct sunxi_mmc_host *mmchost = (struct sunxi_mmc_host *)mmc->priv;
> + unsigned int cmd;
> + unsigned timeout = 0xfffff;
> +
> + cmd = (1U << 31) | (1 << 21) | (1 << 13);
> + writel(cmd, &mmchost->reg->cmd);
> + while ((readl(&mmchost->reg->cmd) & 0x80000000) && timeout--)
> + ;
> + if (!timeout)
> + return -1;
> +
> + writel(readl(&mmchost->reg->rint), &mmchost->reg->rint);
> +
> + return 0;
> +}
> +
> +static int mmc_config_clock(struct mmc *mmc, unsigned div)
> +{
> + struct sunxi_mmc_host *mmchost = (struct sunxi_mmc_host *)mmc->priv;
> + unsigned rval = readl(&mmchost->reg->clkcr);
> +
> + /*
> + * CLKCREG[7:0]: divider
> + * CLKCREG[16]: on/off
> + * CLKCREG[17]: power save
> + */
> + /* Disable Clock */
> + rval &= ~(1 << 16);
> + writel(rval, &mmchost->reg->clkcr);
> + if (mmc_update_clk(mmc))
> + return -1;
> +
> + /* Change Divider Factor */
> + rval &= ~(0xFF);
> + rval |= div;
> + writel(rval, &mmchost->reg->clkcr);
> + if (mmc_update_clk(mmc))
> + return -1;
> + /* Re-enable Clock */
> + rval |= (1 << 16);
> + writel(rval, &mmchost->reg->clkcr);
> +
> + if (mmc_update_clk(mmc))
> + return -1;
> +
> + return 0;
> +}
> +
> +static void mmc_set_ios(struct mmc *mmc)
> +{
> + struct sunxi_mmc_host *mmchost = (struct sunxi_mmc_host *)mmc->priv;
> + unsigned int clkdiv = 0;
> +
> + MMCDBG("set ios: bus_width: %x, clock: %d, mod_clk\n", mmc->bus_width,
> + mmc->clock, mmchost->mod_clk);
> +
> + /* Change clock first */
> + clkdiv = (mmchost->mod_clk + (mmc->clock >> 1)) / mmc->clock / 2;
> + if (mmc->clock)
> + if (mmc_config_clock(mmc, clkdiv)) {
> + mmchost->fatal_err = 1;
> + return;
> + }
> +
> + /* Change bus width */
> + if (mmc->bus_width == 8)
> + writel(2, &mmchost->reg->width);
> + else if (mmc->bus_width == 4)
> + writel(1, &mmchost->reg->width);
> + else
> + writel(0, &mmchost->reg->width);
> +}
> +
> +static int mmc_core_init(struct mmc *mmc)
> +{
> + struct sunxi_mmc_host *mmchost = (struct sunxi_mmc_host *)mmc->priv;
> +
> + /* Reset controller */
> + writel(0x7, &mmchost->reg->gctrl);
> +
> + return 0;
> +}
> +
> +static int mmc_trans_data_by_cpu(struct mmc *mmc, struct mmc_data *data)
> +{
> + struct sunxi_mmc_host *mmchost = (struct sunxi_mmc_host *)mmc->priv;
> + unsigned i;
> + unsigned byte_cnt = data->blocksize * data->blocks;
> + unsigned *buff;
> + unsigned timeout = 0xfffff;
> +
> + if (data->flags & MMC_DATA_READ) {
> + buff = (unsigned int *)data->dest;
> + for (i = 0; i < (byte_cnt >> 2); i++) {
> + while (--timeout
> + && (readl(&mmchost->reg->status) & (1 << 2)))
> + ;
> + if (timeout <= 0)
> + goto out;
> + buff[i] = readl(mmchost->database);
> + timeout = 0xfffff;
> + }
> + } else {
> + buff = (unsigned int *)data->src;
> + for (i = 0; i < (byte_cnt >> 2); i++) {
> + while (--timeout
> + && (readl(&mmchost->reg->status) & (1 << 3)))
> + ;
> + if (timeout <= 0)
> + goto out;
> + writel(buff[i], mmchost->database);
> + timeout = 0xfffff;
> + }
> + }
> +
> +out:
> + if (timeout <= 0)
> + return -1;
> +
> + return 0;
> +}
> +
> +static int mmc_trans_data_by_dma(struct mmc *mmc, struct mmc_data *data)
> +{
> + struct sunxi_mmc_host *mmchost = (struct sunxi_mmc_host *)mmc->priv;
> + struct sunxi_mmc_des *pdes = mmchost->pdes;
> + unsigned byte_cnt = data->blocksize * data->blocks;
> + unsigned char *buff;
> + unsigned des_idx = 0;
> + unsigned buff_frag_num = 0;
> + unsigned remain;
> + unsigned i, rval;
> +
> + buff = data->flags & MMC_DATA_READ ?
> + (unsigned char *)data->dest : (unsigned char *)data->src;
> + buff_frag_num = byte_cnt >> SDXC_DES_NUM_SHIFT;
> +
> + remain = byte_cnt & (SDXC_DES_BUFFER_MAX_LEN - 1);
> + if (remain)
> + buff_frag_num++;
> + else
> + remain = SDXC_DES_BUFFER_MAX_LEN;
> +
> + flush_cache((unsigned long)buff, (unsigned long)byte_cnt);
> + for (i = 0; i < buff_frag_num; i++, des_idx++) {
> + memset((void *)&pdes[des_idx], 0, sizeof(struct sunxi_mmc_des));
> + pdes[des_idx].des_chain = 1;
> + pdes[des_idx].own = 1;
> + pdes[des_idx].dic = 1;
> + if (buff_frag_num > 1 && i != buff_frag_num - 1)
> + pdes[des_idx].data_buf1_sz =
> + (SDXC_DES_BUFFER_MAX_LEN -
> + 1) & SDXC_DES_BUFFER_MAX_LEN;
> + else
> + pdes[des_idx].data_buf1_sz = remain;
> +
> + pdes[des_idx].buf_addr_ptr1 =
> + (u32) buff + i * SDXC_DES_BUFFER_MAX_LEN;
> + if (i == 0)
> + pdes[des_idx].first_des = 1;
> +
> + if (i == buff_frag_num - 1) {
> + pdes[des_idx].dic = 0;
> + pdes[des_idx].last_des = 1;
> + pdes[des_idx].end_of_ring = 1;
> + pdes[des_idx].buf_addr_ptr2 = 0;
> + } else {
> + pdes[des_idx].buf_addr_ptr2 = (u32)&pdes[des_idx + 1];
> + }
> + MMCDBG("frag %d, remain %d, des[%d](%08x): "
> + "[0] = %08x, [1] = %08x, [2] = %08x, [3] = %08x\n",
> + i, remain, des_idx, (u32)&pdes[des_idx],
> + (u32)((u32 *)&pdes[des_idx])[0],
> + (u32)((u32 *)&pdes[des_idx])[1],
> + (u32)((u32 *)&pdes[des_idx])[2],
> + (u32)((u32 *)&pdes[des_idx])[3]);
> + }
> + flush_cache((unsigned long)pdes,
> + sizeof(struct sunxi_mmc_des) * (des_idx + 1));
> +
> + /*
> + * GCTRLREG
> + * GCTRL[2] : DMA reset
> + * GCTRL[5] : DMA enable
> + *
> + * IDMACREG
> + * IDMAC[0] : IDMA soft reset
> + * IDMAC[1] : IDMA fix burst flag
> + * IDMAC[7] : IDMA on
> + *
> + * IDIECREG
> + * IDIE[0] : IDMA transmit interrupt flag
> + * IDIE[1] : IDMA receive interrupt flag
> + */
> + rval = readl(&mmchost->reg->gctrl);
> + writel(rval | (1 << 5) | (1 << 2), &mmchost->reg->gctrl); /* dma enable */
> + writel((1 << 0), &mmchost->reg->dmac); /* idma reset */
> + writel((1 << 1) | (1 << 7), &mmchost->reg->dmac); /* idma on */
> + rval = readl(&mmchost->reg->idie) & (~3);
> + if (data->flags & MMC_DATA_WRITE)
> + rval |= (1 << 0);
> + else
> + rval |= (1 << 1);
> + writel(rval, &mmchost->reg->idie);
> + writel((u32) pdes, &mmchost->reg->dlba);
> + writel((2U << 28) | (7 << 16) | 8, &mmchost->reg->ftrglevel);
> +
> + return 0;
> +}
> +
> +static int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
> + struct mmc_data *data)
> +{
> + struct sunxi_mmc_host *mmchost = (struct sunxi_mmc_host *)mmc->priv;
> + unsigned int cmdval = 0x80000000;
> + signed int timeout = 0;
> + int error = 0;
> + unsigned int status = 0;
> + unsigned int usedma = 0;
> + unsigned int bytecnt = 0;
> +
> + if (mmchost->fatal_err)
> + return -1;
> + if (cmd->resp_type & MMC_RSP_BUSY)
> + MMCDBG("mmc cmd %d check rsp busy\n", cmd->cmdidx);
> + if (cmd->cmdidx == 12)
> + return 0;
> +
> + /*
> + * CMDREG
> + * CMD[5:0] : Command index
> + * CMD[6] : Has response
> + * CMD[7] : Long response
> + * CMD[8] : Check response CRC
> + * CMD[9] : Has data
> + * CMD[10] : Write
> + * CMD[11] : Steam mode
> + * CMD[12] : Auto stop
> + * CMD[13] : Wait previous over
> + * CMD[14] : About cmd
> + * CMD[15] : Send initialization
> + * CMD[21] : Update clock
> + * CMD[31] : Load cmd
> + */
> + if (!cmd->cmdidx)
> + cmdval |= (1 << 15);
> + if (cmd->resp_type & MMC_RSP_PRESENT)
> + cmdval |= (1 << 6);
> + if (cmd->resp_type & MMC_RSP_136)
> + cmdval |= (1 << 7);
> + if (cmd->resp_type & MMC_RSP_CRC)
> + cmdval |= (1 << 8);
> +
> + if (data) {
> + if ((u32) data->dest & 0x3) {
> + error = -1;
> + goto out;
> + }
> +
> + cmdval |= (1 << 9) | (1 << 13);
> + if (data->flags & MMC_DATA_WRITE)
> + cmdval |= (1 << 10);
> + if (data->blocks > 1)
> + cmdval |= (1 << 12);
> + writel(data->blocksize, &mmchost->reg->blksz);
> + writel(data->blocks * data->blocksize, &mmchost->reg->bytecnt);
> + }
> +
> + MMCDBG("mmc %d, cmd %d(0x%08x), arg 0x%08x\n", mmchost->mmc_no,
> + cmd->cmdidx, cmdval | cmd->cmdidx, cmd->cmdarg);
> + writel(cmd->cmdarg, &mmchost->reg->arg);
> +
> + if (!data)
> + writel(cmdval | cmd->cmdidx, &mmchost->reg->cmd);
> +
> + /*
> + * transfer data and check status
> + * STATREG[2] : FIFO empty
> + * STATREG[3] : FIFO full
> + */
> + if (data) {
> + int ret = 0;
> +
> + bytecnt = data->blocksize * data->blocks;
> + MMCDBG("trans data %d bytes\n", bytecnt);
> +#if defined(CONFIG_MMC_SUNXI_USE_DMA) && !defined(CONFIG_SPL_BUILD)
> + if (bytecnt > 64) {
> +#else
> + if (0) {
> +#endif
> + usedma = 1;
> + writel(readl(&mmchost->reg->gctrl) & (~0x80000000),
> + &mmchost->reg->gctrl);
> + ret = mmc_trans_data_by_dma(mmc, data);
> + writel(cmdval | cmd->cmdidx, &mmchost->reg->cmd);
> + } else {
> + writel(readl(&mmchost->reg->gctrl) | 0x80000000,
> + &mmchost->reg->gctrl);
> + writel(cmdval | cmd->cmdidx, &mmchost->reg->cmd);
> + ret = mmc_trans_data_by_cpu(mmc, data);
> + }
> + if (ret) {
> + error = readl(&mmchost->reg->rint) & 0xbfc2;
> + goto out;
> + }
> + }
> +
> + timeout = 0xfffff;
> + do {
> + status = readl(&mmchost->reg->rint);
> + if (!timeout-- || (status & 0xbfc2)) {
> + error = status & 0xbfc2;
> + MMCDBG("cmd timeout %x\n", error);
> + goto out;
> + }
> + } while (!(status & 0x4));
> +
> + if (data) {
> + unsigned done = 0;
> + timeout = usedma ? 0xffff * bytecnt : 0xffff;
> + MMCDBG("cacl timeout %x\n", timeout);
> + do {
> + status = readl(&mmchost->reg->rint);
> + if (!timeout-- || (status & 0xbfc2)) {
> + error = status & 0xbfc2;
> + MMCDBG("data timeout %x\n", error);
> + goto out;
> + }
> + if (data->blocks > 1)
> + done = status & (1 << 14);
> + else
> + done = status & (1 << 3);
> + } while (!done);
> + }
> +
> + if (cmd->resp_type & MMC_RSP_BUSY) {
> + timeout = 0xfffff;
> + do {
> + status = readl(&mmchost->reg->status);
> + if (!timeout--) {
> + error = -1;
> + MMCDBG("busy timeout\n");
> + goto out;
> + }
> + } while (status & (1 << 9));
> + }
> +
> + if (cmd->resp_type & MMC_RSP_136) {
> + cmd->response[0] = readl(&mmchost->reg->resp3);
> + cmd->response[1] = readl(&mmchost->reg->resp2);
> + cmd->response[2] = readl(&mmchost->reg->resp1);
> + cmd->response[3] = readl(&mmchost->reg->resp0);
> + MMCDBG("mmc resp 0x%08x 0x%08x 0x%08x 0x%08x\n",
> + cmd->response[3], cmd->response[2],
> + cmd->response[1], cmd->response[0]);
> + } else {
> + cmd->response[0] = readl(&mmchost->reg->resp0);
> + MMCDBG("mmc resp 0x%08x\n", cmd->response[0]);
> + }
> +out:
> + if (data && usedma) {
> + /* IDMASTAREG
> + * IDST[0] : idma tx int
> + * IDST[1] : idma rx int
> + * IDST[2] : idma fatal bus error
> + * IDST[4] : idma descriptor invalid
> + * IDST[5] : idma error summary
> + * IDST[8] : idma normal interrupt sumary
> + * IDST[9] : idma abnormal interrupt sumary
> + */
> + status = readl(&mmchost->reg->idst);
> + writel(status, &mmchost->reg->idst);
> + writel(0, &mmchost->reg->idie);
> + writel(0, &mmchost->reg->dmac);
> + writel(readl(&mmchost->reg->gctrl) & (~(1 << 5)),
> + &mmchost->reg->gctrl);
> + }
> + if (error) {
> + writel(0x7, &mmchost->reg->gctrl);
> + mmc_update_clk(mmc);
> + MMCDBG("mmc cmd %d err 0x%08x\n", cmd->cmdidx, error);
> + }
> + writel(0xffffffff, &mmchost->reg->rint);
> + writel(readl(&mmchost->reg->gctrl) | (1 << 1), &mmchost->reg->gctrl);
> +
> + if (error)
> + return -1;
> + else
> + return 0;
> +}
> +
> +int sunxi_mmc_init(int sdc_no)
> +{
> + struct mmc *mmc;
> +
> + memset(&mmc_dev[sdc_no], 0, sizeof(struct mmc));
> + memset(&mmc_host[sdc_no], 0, sizeof(struct sunxi_mmc_host));
> + mmc = &mmc_dev[sdc_no];
> +
> + sprintf(mmc->name, "SUNXI SD/MMC");
> + mmc->priv = &mmc_host[sdc_no];
> + mmc->send_cmd = mmc_send_cmd;
> + mmc->set_ios = mmc_set_ios;
> + mmc->init = mmc_core_init;
> +
> + mmc->voltages = MMC_VDD_32_33 | MMC_VDD_33_34;
> + mmc->host_caps = MMC_MODE_4BIT;
> + mmc->host_caps |= MMC_MODE_HS_52MHz | MMC_MODE_HS;
> +
> + mmc->f_min = 400000;
> + mmc->f_max = 52000000;
> +
> + mmc_host[sdc_no].pdes = (struct sunxi_mmc_des *)0x50000000;
> + mmc_resource_init(sdc_no);
> + mmc_clk_io_on(sdc_no);
> +
> + mmc_register(mmc);
> +
> + return 0;
> +}
> diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
> index 33309f3..8a026e0 100644
> --- a/include/configs/sunxi-common.h
> +++ b/include/configs/sunxi-common.h
> @@ -77,6 +77,16 @@
> #define CONFIG_INITRD_TAG
> #define CONFIG_CMDLINE_EDITING
>
> +/* mmc config */
> +#define CONFIG_MMC
> +#define CONFIG_GENERIC_MMC
> +#define CONFIG_CMD_MMC
> +#define CONFIG_MMC_SUNXI
> +#define CONFIG_MMC_SUNXI_SLOT 0 /* which mmc slot to use, could be 0,1,2,3 */
> +#define CONFIG_MMC_SUNXI_USE_DMA
> +#define CONFIG_ENV_IS_IN_MMC
> +#define CONFIG_SYS_MMC_ENV_DEV CONFIG_MMC_SUNXI_SLOT /* env in which mmc */
> +
> /*
> * Size of malloc() pool
> * 1MB = 0x100000, 0x100000 = 1024 * 1024
> @@ -127,9 +137,7 @@
> #define CONFIG_SYS_MONITOR_LEN (256 << 10) /* 256 KB */
> #define CONFIG_IDENT_STRING " Allwinner Technology "
>
> -#define CONFIG_ENV_IS_NOWHERE /* No storage defined yet */
> -
> -#define CONFIG_ENV_OFFSET (544 << 10) /* (8 + 24 + 512)KB */
> +#define CONFIG_ENV_OFFSET (544 << 10) /* (8 + 24 + 512)KB */

The comment moving should go in the first patch.

> #define CONFIG_ENV_SIZE (128 << 10) /* 128KB */
>
> #define CONFIG_BOOTCOMMAND \
> --
> 1.7.7.6

Luka