From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Kisky Date: Wed, 28 Nov 2012 19:42:01 -0700 Subject: [U-Boot] [PATCH V4 01/11] imximage: mx53 needs transfer length a multiple of 512 In-Reply-To: <20121128213533.14C6220120D@gemini.denx.de> References: <1349315254-21151-9-git-send-email-troy.kisky@boundarydevices.com> <1354066303-29762-1-git-send-email-troy.kisky@boundarydevices.com> <1354066303-29762-2-git-send-email-troy.kisky@boundarydevices.com> <20121128092758.D8E4F20104E@gemini.denx.de> <50B65583.1070309@boundarydevices.com> <20121128202555.5B849201208@gemini.denx.de> <50B67C99.8080609@boundarydevices.com> <20121128213533.14C6220120D@gemini.denx.de> Message-ID: <50B6CB79.4030007@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/28/2012 2:35 PM, Wolfgang Denk wrote: > Dear Troy Kisky, > > In message <50B67C99.8080609@boundarydevices.com> you wrote: >> But the reason I didn't include common.h is because of the target specific >> files that it also includes. Would you mind if I moved > Why would these hurt? They don't anywhere else. > I'm not saying that including common.h wouldn't work. I'm saying that it seems wrong to include target specific include files in an executable that should generate the same code regardless of the target selected. I really don't care enough to argue. I just want you to understand why I did it the way I did. It wasn't because I was crazy, or lazy. We just hold different priorities. Would you like to see the Linux way of ALIGN, or ROUND? Now, back to the other topic you raised. Should I apply the bug work-around for all version 2 headers, or find a way to distinguish mx53/mx6? Thanks Troy