public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2 2/4] at91sam9x5: enable USB support for 9x5ek board.
Date: Thu, 29 Nov 2012 13:22:03 +0800	[thread overview]
Message-ID: <50B6F0FB.5050307@atmel.com> (raw)
In-Reply-To: <1354103289-967-3-git-send-email-richard.genoud@gmail.com>

Hi Richard,

On 11/28/2012 19:48, Richard Genoud wrote:
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> ---
>   arch/arm/cpu/arm926ejs/at91/at91sam9x5_devices.c |   10 ++++++++++
>   arch/arm/include/asm/arch-at91/at91sam9x5.h      |    2 ++
>   board/atmel/at91sam9x5ek/at91sam9x5ek.c          |    3 +++
>   drivers/usb/host/ohci-at91.c                     |    6 ++++--
>   4 files changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/at91/at91sam9x5_devices.c b/arch/arm/cpu/arm926ejs/at91/at91sam9x5_devices.c
> index 9348552..f2a05c8 100644
> --- a/arch/arm/cpu/arm926ejs/at91/at91sam9x5_devices.c
> +++ b/arch/arm/cpu/arm926ejs/at91/at91sam9x5_devices.c
> @@ -193,6 +193,16 @@ void at91_spi1_hw_init(unsigned long cs_mask)
>   }
>   #endif
>
> +#if defined(CONFIG_USB_OHCI_NEW) || defined(CONFIG_USB_EHCI)
> +void at91_uhp_hw_init(void)
> +{
> +	/* Enable VBus on UHP ports */
> +	at91_set_pio_output(AT91_PIO_PORTD, 18, 0); /* port A */
> +	at91_set_pio_output(AT91_PIO_PORTD, 19, 0); /* port B */
> +	at91_set_pio_output(AT91_PIO_PORTD, 20, 0); /* port C */
> +}
> +#endif
> +

As port C doesn't support EHCI, so, I think we should deal with this 
carefully.
---<8---
#if OHCI
#else EHCI
#endif
--->8---
I think this will be better.

Best Regards
Bo Shen

  reply	other threads:[~2012-11-29  5:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28 11:48 [U-Boot] [PATCHv2 0/4]enable USB OHCI on sam9x5ek boards Richard Genoud
2012-11-28 11:48 ` [U-Boot] [PATCHv2 1/4] usb documentation: fix typo Richard Genoud
2012-11-28 11:48 ` [U-Boot] [PATCHv2 2/4] at91sam9x5: enable USB support for 9x5ek board Richard Genoud
2012-11-29  5:22   ` Bo Shen [this message]
2012-11-30  9:06     ` Richard Genoud
2012-11-28 11:48 ` [U-Boot] [PATCHv2 3/4] at91sam9x5ek: regroup FAT/DOS features Richard Genoud
2012-11-28 11:48 ` [U-Boot] [PATCHv2 4/4] at91sam9x5ek: add USB configuration Richard Genoud
2012-11-29  5:22   ` Bo Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B6F0FB.5050307@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox