From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: Add an mmcsilent option
Date: Thu, 29 Nov 2012 10:57:21 -0500 [thread overview]
Message-ID: <50B785E1.9080106@ti.com> (raw)
In-Reply-To: <48BE27D8-0949-4A7C-9A27-ADCE0D3D507D@antoniou-consulting.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/28/12 11:50, Pantelis Antoniou wrote:
> Hi Andy,
>
> On Nov 28, 2012, at 6:49 PM, Andy Fleming wrote:
>
>>
>>
>>
>> On Thu, Nov 29, 2012 at 1:34 AM, Pantelis Antoniou
>> <panto@antoniou-consulting.com> wrote: When using MMC commands
>> for dfu there is considerable noise. Suppress mmc messages when
>> mmcsilent is set.
>>
>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
>>
>>
>> I'm not familiar with DFU mode, but is there a reason it's
>> invoking the command line call, rather than accessing the card
>> programmatically? The reason that printf is there is because it's
>> a user-facing interface, rather than a software-facing
>> interface.
>>
>
> No there is not. It's just what was there and the messages were
> irritating. I would prefer a software interface TBH.
I'm trying to recall. Part of the issue was that, I believe, there
wasn't an easy software interface to all of the MMC commands that we
needed to use here. It might however have boiled down to as a future
clean-up, abstract things so that cmd_mmc and cmd_dfu could make use
of the same lower level code.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iQIcBAEBAgAGBQJQt4XhAAoJENk4IS6UOR1WnUcQAJDRFObh3mxSRccDDtsJ4Cab
RBDnAdV6KmiCEJF3x2aWtlUdQVVUI15lPwqG6oKHup5s4oNEupSgvmvdXE3I8lCs
dWlDU3pSRlIHMFIMJbd6Cy4nYX0rEwxXVEtlujZ875y+wx6sG25FdA7NoQ42uxif
c+Oyt/2aUOXx0z2oFsrB7dIadF3cWxglwhla4ob2XBS4w2RYEmti94Vmp4drjlmj
s+DMbS3h9Ar9tUIty1sFGUFVU4DycgeZ2COS3IezbcD4E+H6vTGchhZpxFgzsOwo
KydHMRsbMvo3px42fE4frFto/n/UwIiS/eSdnN7vpILdZUhH6MmzmPKeLTYpxyGb
HiZWnttVmbZHGGLZ/i95XIbQe9PeLsA0WEy5sZrBrn/2JgQ5ktJdpoWHePNk/4VU
jO+DItIUWlh5cAsfsi2WFi42MNwMvbkZTItKuQrMpWSTwjmZIiWiIlHmFu5DUo5b
2TNReo2Ybr+7ajb4jz3rBbyVLGJdSPE0lJ+ZUkn6qjf/v3Sz0Z2QsF41keN499PB
RaVmLvPVH96r/0jZQN0zlEwPX5f8g5ULnUBHsjLGDo8uc0ZzR9aNGq2bOvFSXOVO
bZ/qedEHZvqrGxTkDO5LCpGwQPt8UigL7s9FWfkoXgZLP+4y7D+X4tPOYw3VbV+6
RTnJU9MduHBf6AU7XgRI
=55le
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2012-11-29 15:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 7:34 [U-Boot] [PATCH] mmc: Add an mmcsilent option Pantelis Antoniou
2012-11-28 16:04 ` Wolfgang Denk
2012-11-28 16:49 ` Andy Fleming
2012-11-28 16:50 ` Pantelis Antoniou
2012-11-29 15:57 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B785E1.9080106@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox