From: Nikita Kiryanov <nikita@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cm-t35: add USB host support
Date: Sun, 02 Dec 2012 09:11:48 +0200 [thread overview]
Message-ID: <50BAFF34.3070206@compulab.co.il> (raw)
In-Reply-To: <201211282336.31075.marex@denx.de>
Hi Marek Vasut,
On 11/29/2012 12:36 AM, Marek Vasut wrote:
> Dear Nikita Kiryanov,
>
> [...]
>
>> + twl4030_i2c_read_u8(TWL4030_CHIP_GPIO, &val,
>> + TWL4030_BASEADD_GPIO + 0x03);
>> + val |= 0xC0;
>
> What are these magic values here please?
val |= 0xC0 is simply setting bits 7 and 6 to 1.
As for TWL4030_BASEADD_GPIO + 0x03/0x0C, I'll address them in a V2.
>
>> + /* Set GPIO6 and GPIO7 of TPS65930 as output */
>> + twl4030_i2c_write_u8(TWL4030_CHIP_GPIO, val,
>> + TWL4030_BASEADD_GPIO + 0x03);
>> + /* Take both PHYs out of reset */
>> + twl4030_i2c_write_u8(TWL4030_CHIP_GPIO, 0xC0,
>> + TWL4030_BASEADD_GPIO + 0x0C);
>> + udelay(1);
>> +
>> + return omap_ehci_hcd_init(&usbhs_bdata);
> [...]
>
> Best regards,
> Marek Vasut
>
--
Regards,
Nikita.
next prev parent reply other threads:[~2012-12-02 7:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 13:23 [U-Boot] [PATCH] cm-t35: add USB host support Nikita Kiryanov
2012-11-28 22:36 ` Marek Vasut
2012-12-02 7:11 ` Nikita Kiryanov [this message]
2012-12-02 7:47 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BAFF34.3070206@compulab.co.il \
--to=nikita@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox