From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nikita Kiryanov <nikita@compulab.co.il>
Date: Sun, 02 Dec 2012 09:11:48 +0200
Subject: [U-Boot] [PATCH] cm-t35: add USB host support
In-Reply-To: <201211282336.31075.marex@denx.de>
References: <1354109008-12124-1-git-send-email-nikita@compulab.co.il>
	<201211282336.31075.marex@denx.de>
Message-ID: <50BAFF34.3070206@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marek Vasut,

On 11/29/2012 12:36 AM, Marek Vasut wrote:
> Dear Nikita Kiryanov,
>
> [...]
>
>> +	twl4030_i2c_read_u8(TWL4030_CHIP_GPIO, &val,
>> +						TWL4030_BASEADD_GPIO + 0x03);
>> +	val |= 0xC0;
>
> What are these magic values here please?

val |= 0xC0 is simply setting bits 7 and 6 to 1.

As for TWL4030_BASEADD_GPIO + 0x03/0x0C, I'll address them in a V2.

>
>> +	/* Set GPIO6 and GPIO7 of TPS65930 as output */
>> +	twl4030_i2c_write_u8(TWL4030_CHIP_GPIO, val,
>> +						TWL4030_BASEADD_GPIO + 0x03);
>> +	/* Take both PHYs out of reset */
>> +	twl4030_i2c_write_u8(TWL4030_CHIP_GPIO, 0xC0,
>> +						TWL4030_BASEADD_GPIO + 0x0C);
>> +	udelay(1);
>> +
>> +	return omap_ehci_hcd_init(&usbhs_bdata);
> [...]
>
> Best regards,
> Marek Vasut
>


-- 
Regards,
Nikita.