From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 03 Dec 2012 10:12:23 +0100 Subject: [U-Boot] [PATCH V4 01/11] imximage: mx53 needs transfer length a multiple of 512 In-Reply-To: <20121128213533.14C6220120D@gemini.denx.de> References: <1349315254-21151-9-git-send-email-troy.kisky@boundarydevices.com> <1354066303-29762-1-git-send-email-troy.kisky@boundarydevices.com> <1354066303-29762-2-git-send-email-troy.kisky@boundarydevices.com> <20121128092758.D8E4F20104E@gemini.denx.de> <50B65583.1070309@boundarydevices.com> <20121128202555.5B849201208@gemini.denx.de> <50B67C99.8080609@boundarydevices.com> <20121128213533.14C6220120D@gemini.denx.de> Message-ID: <50BC6CF7.1000809@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 28/11/2012 22:35, Wolfgang Denk wrote: > Dear Troy Kisky, > > In message <50B67C99.8080609@boundarydevices.com> you wrote: >> >> But the reason I didn't include common.h is because of the target specific >> files that it also includes. Would you mind if I moved > > Why would these hurt? They don't anywhere else. Personally, I think that mkimage as generic tool should not include common.h. Doing that, it does not allow to compile mkimage without running config, and let's think that we need a different mkimage for each target, and that is not true. This will break also support from distros, because their packages (for example, u-boot-tools, uboot-mkimage under Ubuntu) are compiled without configuring u-boot - and I think it is correct. IMHO we are discussing about a single macro. We can let it in mkimage as in patch and move it in a general file only if we will have a use case with a bunch of macros. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================