public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] mx28: Remove SET, CLR, TOG ops from PLLxCTRL1 registers
@ 2012-11-25  0:03 Marek Vasut
  2012-11-26 16:26 ` Otavio Salvador
  2012-12-04  7:52 ` Stefano Babic
  0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2012-11-25  0:03 UTC (permalink / raw)
  To: u-boot

These registers don't have _SET, _CLR and _TOG at the respective offsets
available, these registers has to be toggled via R-M-W if needed. Thus do
not export these offsets anymore.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Stefano Babic <sbabic@denx.de>
---
 arch/arm/include/asm/arch-mxs/regs-clkctrl-mx28.h |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/include/asm/arch-mxs/regs-clkctrl-mx28.h b/arch/arm/include/asm/arch-mxs/regs-clkctrl-mx28.h
index b662fbe..23e9adc 100644
--- a/arch/arm/include/asm/arch-mxs/regs-clkctrl-mx28.h
+++ b/arch/arm/include/asm/arch-mxs/regs-clkctrl-mx28.h
@@ -31,9 +31,11 @@
 #ifndef	__ASSEMBLY__
 struct mxs_clkctrl_regs {
 	mxs_reg_32(hw_clkctrl_pll0ctrl0)	/* 0x00 */
-	mxs_reg_32(hw_clkctrl_pll0ctrl1)	/* 0x10 */
+	uint32_t	hw_clkctrl_pll0ctrl1;	/* 0x10 */
+	uint32_t	reserved_pll0ctrl1[3];	/* 0x14-0x1c */
 	mxs_reg_32(hw_clkctrl_pll1ctrl0)	/* 0x20 */
-	mxs_reg_32(hw_clkctrl_pll1ctrl1)	/* 0x30 */
+	uint32_t	hw_clkctrl_pll1ctrl1;	/* 0x30 */
+	uint32_t	reserved_pll1ctrl1[3];	/* 0x34-0x3c */
 	mxs_reg_32(hw_clkctrl_pll2ctrl0)	/* 0x40 */
 	mxs_reg_32(hw_clkctrl_cpu)		/* 0x50 */
 	mxs_reg_32(hw_clkctrl_hbus)		/* 0x60 */
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] mx28: Remove SET, CLR, TOG ops from PLLxCTRL1 registers
  2012-11-25  0:03 [U-Boot] [PATCH] mx28: Remove SET, CLR, TOG ops from PLLxCTRL1 registers Marek Vasut
@ 2012-11-26 16:26 ` Otavio Salvador
  2012-12-04  7:52 ` Stefano Babic
  1 sibling, 0 replies; 3+ messages in thread
From: Otavio Salvador @ 2012-11-26 16:26 UTC (permalink / raw)
  To: u-boot

On Sat, Nov 24, 2012 at 10:03 PM, Marek Vasut <marex@denx.de> wrote:
> These registers don't have _SET, _CLR and _TOG at the respective offsets
> available, these registers has to be toggled via R-M-W if needed. Thus do
> not export these offsets anymore.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>

Acked-by: Otavio Salvador <otavio@ossystems.com.br>

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] mx28: Remove SET, CLR, TOG ops from PLLxCTRL1 registers
  2012-11-25  0:03 [U-Boot] [PATCH] mx28: Remove SET, CLR, TOG ops from PLLxCTRL1 registers Marek Vasut
  2012-11-26 16:26 ` Otavio Salvador
@ 2012-12-04  7:52 ` Stefano Babic
  1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2012-12-04  7:52 UTC (permalink / raw)
  To: u-boot

On 25/11/2012 01:03, Marek Vasut wrote:
> These registers don't have _SET, _CLR and _TOG at the respective offsets
> available, these registers has to be toggled via R-M-W if needed. Thus do
> not export these offsets anymore.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---


Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-12-04  7:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-25  0:03 [U-Boot] [PATCH] mx28: Remove SET, CLR, TOG ops from PLLxCTRL1 registers Marek Vasut
2012-11-26 16:26 ` Otavio Salvador
2012-12-04  7:52 ` Stefano Babic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox