From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] MMC: DWMMC: Modified fifo size computation
Date: Thu, 06 Dec 2012 12:59:47 +0900 [thread overview]
Message-ID: <50C01833.6010500@samsung.com> (raw)
In-Reply-To: <1354714297-11568-2-git-send-email-amarendra.xt@samsung.com>
It looks good to me.
Added minor comment.
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 12/05/2012 10:31 PM, Amar wrote:
> The current implementation of fifo size computation was giving improper
> values for eMMC channel. Modified the computation as per user manual.
>
> Signed-off-by: Amarendra Reddy <amarendra.xt@samsung.com>
> ---
> drivers/mmc/dw_mmc.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> index 4070d4e..62dc152 100644
> --- a/drivers/mmc/dw_mmc.c
> +++ b/drivers/mmc/dw_mmc.c
> @@ -332,6 +332,8 @@ static int dwmci_init(struct mmc *mmc)
> dwmci_writel(host, DWMCI_BMOD, 1);
>
> fifo_size = dwmci_readl(host, DWMCI_FIFOTH);
> + fifo_size = ((fifo_size & RX_WMARK(0xFFF)) >> 16) + 1;
How about using like FIFO_SIZE_MASK?
> +
> if (host->fifoth_val)
> fifoth_val = host->fifoth_val;
> else
>
next prev parent reply other threads:[~2012-12-06 3:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 13:31 [U-Boot] [PATCH 0/4] EXYNOS5: Enable dwmmc Amar
2012-12-05 13:31 ` [U-Boot] [PATCH 1/4] MMC: DWMMC: Modified fifo size computation Amar
2012-12-06 3:59 ` Jaehoon Chung [this message]
2012-12-08 19:49 ` Simon Glass
2012-12-10 2:21 ` Jaehoon Chung
2012-12-10 6:09 ` Amarendra Reddy
2013-03-27 5:03 ` Minkyu Kang
2013-03-27 5:18 ` Amarendra Reddy
2013-03-27 5:39 ` Minkyu Kang
2012-12-05 13:31 ` [U-Boot] [PATCH 2/4] MMC: EXYNOS: Added call back function for clock get Amar
2012-12-06 4:03 ` Jaehoon Chung
2013-03-27 5:14 ` Minkyu Kang
2013-03-27 5:38 ` Amarendra Reddy
2013-03-27 7:40 ` Minkyu Kang
2013-03-27 8:01 ` Amarendra Reddy
2012-12-05 13:31 ` [U-Boot] [PATCH 3/4] EXYNOS: CLOCK: Initialised the local variable Amar
2012-12-06 4:04 ` Jaehoon Chung
2012-12-05 13:31 ` [U-Boot] [PATCH 4/4] SMDK5250: Initialise and enable dwmmc channels Amar
2012-12-06 4:08 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C01833.6010500@samsung.com \
--to=jh80.chung@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox