public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] EXYNOS: CLOCK: Initialised the local variable
Date: Thu, 06 Dec 2012 13:04:28 +0900	[thread overview]
Message-ID: <50C0194C.7000907@samsung.com> (raw)
In-Reply-To: <1354714297-11568-4-git-send-email-amarendra.xt@samsung.com>

Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

On 12/05/2012 10:31 PM, Amar wrote:
> This patch initialises the local variable 'shift' to zero to avoid
> improper extraction of ratio and pre-ratio divider values. Extraction of
> improper values was happening due to garbage value present in local variable.
> 
> Signed-off-by: Amarendra Reddy <amarendra.xt@samsung.com>
> ---
>  arch/arm/cpu/armv7/exynos/clock.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c
> index 731bbff..0bcf05f 100644
> --- a/arch/arm/cpu/armv7/exynos/clock.c
> +++ b/arch/arm/cpu/armv7/exynos/clock.c
> @@ -379,7 +379,7 @@ static unsigned long exynos4_get_mmc_clk(int dev_index)
>  		(struct exynos4_clock *)samsung_get_base_clock();
>  	unsigned long uclk, sclk;
>  	unsigned int sel, ratio, pre_ratio;
> -	int shift;
> +	int shift = 0;
>  
>  	sel = readl(&clk->src_fsys);
>  	sel = (sel >> (dev_index << 2)) & 0xf;
> @@ -428,7 +428,7 @@ static unsigned long exynos5_get_mmc_clk(int dev_index)
>  		(struct exynos5_clock *)samsung_get_base_clock();
>  	unsigned long uclk, sclk;
>  	unsigned int sel, ratio, pre_ratio;
> -	int shift;
> +	int shift = 0;
>  
>  	sel = readl(&clk->src_fsys);
>  	sel = (sel >> (dev_index << 2)) & 0xf;
> 

  reply	other threads:[~2012-12-06  4:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-05 13:31 [U-Boot] [PATCH 0/4] EXYNOS5: Enable dwmmc Amar
2012-12-05 13:31 ` [U-Boot] [PATCH 1/4] MMC: DWMMC: Modified fifo size computation Amar
2012-12-06  3:59   ` Jaehoon Chung
2012-12-08 19:49     ` Simon Glass
2012-12-10  2:21       ` Jaehoon Chung
2012-12-10  6:09         ` Amarendra Reddy
2013-03-27  5:03   ` Minkyu Kang
2013-03-27  5:18     ` Amarendra Reddy
2013-03-27  5:39       ` Minkyu Kang
2012-12-05 13:31 ` [U-Boot] [PATCH 2/4] MMC: EXYNOS: Added call back function for clock get Amar
2012-12-06  4:03   ` Jaehoon Chung
2013-03-27  5:14   ` Minkyu Kang
2013-03-27  5:38     ` Amarendra Reddy
2013-03-27  7:40       ` Minkyu Kang
2013-03-27  8:01         ` Amarendra Reddy
2012-12-05 13:31 ` [U-Boot] [PATCH 3/4] EXYNOS: CLOCK: Initialised the local variable Amar
2012-12-06  4:04   ` Jaehoon Chung [this message]
2012-12-05 13:31 ` [U-Boot] [PATCH 4/4] SMDK5250: Initialise and enable dwmmc channels Amar
2012-12-06  4:08   ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C0194C.7000907@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox