From: Vipin Kumar <vipin.kumar@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fsmc: Skip BBT scan for bad block management
Date: Fri, 7 Dec 2012 10:08:32 +0530 [thread overview]
Message-ID: <50C172C8.3050202@st.com> (raw)
In-Reply-To: <1354822033.8062.10@snotra>
On 12/7/2012 12:57 AM, Scott Wood wrote:
> On 12/06/2012 01:21:28 AM, Vipin Kumar wrote:
>> This patch forces to read the bad block marker from location 0 in
>> large page
>> nand devices and location 5 in small page devices.
>>
>> Signed-off-by: Vipin Kumar<vipin.kumar@st.com>
>> Reviewed-by: Shiraz Hashim<shiraz.hashim@st.com>
>> ---
>> drivers/mtd/nand/fsmc_nand.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/fsmc_nand.c
>> b/drivers/mtd/nand/fsmc_nand.c
>> index 7a61d88..bce4298 100644
>> --- a/drivers/mtd/nand/fsmc_nand.c
>> +++ b/drivers/mtd/nand/fsmc_nand.c
>> @@ -433,7 +433,7 @@ int fsmc_nand_init(struct nand_chip *nand)
>> writel(FSMC_THIZ_1 | FSMC_THOLD_4 | FSMC_TWAIT_6 | FSMC_TSET_0,
>> &fsmc_regs_p->attrib);
>>
>> - nand->options = 0;
>> + nand->options = NAND_SKIP_BBTSCAN;
>> #if defined(CONFIG_SYS_FSMC_NAND_16BIT)
>> nand->options |= NAND_BUSWIDTH_16;
>> #endif
>
> I don't think this will change the bad block marker behavior -- just
> whether you use a BBT. Why do you need this? Why not
> NAND_USE_FLASH_BBT instead?
>
It's because the BootROM which is fused in the device itself (ie
non-modifiable) is going to read the bad block markers from the oob area.
Which means that anything written via u-boot is non-readable if it uses
flash bbt
> -Scott
>
next prev parent reply other threads:[~2012-12-07 4:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 7:21 [U-Boot] [PATCH] fsmc: Skip BBT scan for bad block management Vipin Kumar
2012-12-06 19:27 ` Scott Wood
2012-12-07 4:38 ` Vipin Kumar [this message]
2012-12-08 0:18 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C172C8.3050202@st.com \
--to=vipin.kumar@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox