public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH resend 1/2] u-boot/spl: Add u-boot-spl.img to u-boot targets
Date: Fri, 07 Dec 2012 11:44:59 +0100	[thread overview]
Message-ID: <50C1C8AB.6020302@denx.de> (raw)
In-Reply-To: <50C1BB2E.7090806@st.com>

On 12/07/2012 10:47 AM, Vipin Kumar wrote:
> On 12/6/2012 5:38 PM, Stefan Roese wrote:
>> On 12/06/2012 10:29 AM, Vipin Kumar wrote:
>>> Signed-off-by: Vipin Kumar<vipin.kumar@st.com>
>>
>> Is this new build target really needed? Please take a look at the
>> recently added/renamed targets (e.g. u-boot-with-spl.bin or u-boot-img.bin).
>>
> 
> Hmm, this is an mkimage version of spl binary. This mkimage header is 
> detected by the BootROM in spear devices for loading and booting the SPL 
> binary

Yes, I remember this from the SPEAr600. I introduced a new build target
for this: u-boot.spr. Take a look at the commit:

94aebe6cc3111c7c9e3cd1311cc9793d01cc3ded

    Makefile: Add u-boot.spr build target (SPEAr)

    On x600 (SPEAr600) U-Boot is appended to U-Boot SPL. Both images are
    created using mkimage (crc etc), so that the ROM bootloader can check
    its integrity. Padding needs to be done to the SPL image (with
    mkimage header) and not the binary. Otherwise the resulting image
    which is loaded/copied by the ROM bootloader to SRAM doesn't fit.
    The resulting image containing both U-Boot images is called u-boot.spr.


Or does your patch "only" introduce the mkimage SPL image version?

Then please consolidate this with the u-boot.spr build target.

Thanks,
Stefan

  reply	other threads:[~2012-12-07 10:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-06  9:29 [U-Boot] [PATCH resend 1/2] u-boot/spl: Add u-boot-spl.img to u-boot targets Vipin Kumar
2012-12-06  9:29 ` [U-Boot] [PATCH resend 2/2] arm/boards: Define a new config option CONFIG_BOOT_PARAMS_P Vipin Kumar
2012-12-06  9:44   ` Stefan Roese
2012-12-06  9:56     ` Vipin Kumar
2012-12-06 11:26       ` Stefan Roese
2012-12-07  9:40         ` Vipin Kumar
2012-12-07 14:47           ` Wolfgang Denk
2012-12-17  8:15             ` Vipin Kumar
2012-12-06 12:08 ` [U-Boot] [PATCH resend 1/2] u-boot/spl: Add u-boot-spl.img to u-boot targets Stefan Roese
2012-12-07  9:47   ` Vipin Kumar
2012-12-07 10:44     ` Stefan Roese [this message]
2012-12-07 11:55       ` Vipin Kumar
2012-12-07 11:59         ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C1C8AB.6020302@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox