From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vipin Kumar <vipin.kumar@st.com>
Date: Fri, 7 Dec 2012 17:25:19 +0530
Subject: [U-Boot] [PATCH resend 1/2] u-boot/spl: Add u-boot-spl.img to
	u-boot targets
In-Reply-To: <50C1C8AB.6020302@denx.de>
References: <0914ca07f3fa7549188e349e7a0a32c3d6521321.1354786138.git.vipin.kumar@st.com>
	<50C08AA5.2010006@denx.de> <50C1BB2E.7090806@st.com>
	<50C1C8AB.6020302@denx.de>
Message-ID: <50C1D927.60506@st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 12/7/2012 4:14 PM, Stefan Roese wrote:
> On 12/07/2012 10:47 AM, Vipin Kumar wrote:
>> On 12/6/2012 5:38 PM, Stefan Roese wrote:
>>> On 12/06/2012 10:29 AM, Vipin Kumar wrote:
>>>> Signed-off-by: Vipin Kumar<vipin.kumar@st.com>
>>>
>>> Is this new build target really needed? Please take a look at the
>>> recently added/renamed targets (e.g. u-boot-with-spl.bin or u-boot-img.bin).
>>>
>>
>> Hmm, this is an mkimage version of spl binary. This mkimage header is
>> detected by the BootROM in spear devices for loading and booting the SPL
>> binary
>
> Yes, I remember this from the SPEAr600. I introduced a new build target
> for this: u-boot.spr. Take a look at the commit:
>

Yes, I remember

> 94aebe6cc3111c7c9e3cd1311cc9793d01cc3ded
>
>      Makefile: Add u-boot.spr build target (SPEAr)
>
>      On x600 (SPEAr600) U-Boot is appended to U-Boot SPL. Both images are
>      created using mkimage (crc etc), so that the ROM bootloader can check
>      its integrity. Padding needs to be done to the SPL image (with
>      mkimage header) and not the binary. Otherwise the resulting image
>      which is loaded/copied by the ROM bootloader to SRAM doesn't fit.
>      The resulting image containing both U-Boot images is called u-boot.spr.
>
>
> Or does your patch "only" introduce the mkimage SPL image version?
>

Yes, it introduces only mkimage SPL image version. This is necessary for 
a few booting options where we absolutely require a different SPL binary 
with an mkimage header

> Then please consolidate this with the u-boot.spr build target.
>

You mean u-boot.spr can use this u-boot-spl.img. Yes, I will do that in v2

> Thanks,
> Stefan
> .
>

Vipin