public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Piotr Wilczek <p.wilczek@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] universal_c210: fix compiler error and compiler warning
Date: Mon, 10 Dec 2012 11:28:39 +0100	[thread overview]
Message-ID: <50C5B957.1080704@samsung.com> (raw)
In-Reply-To: <50C58623.3090308@samsung.com>

On 12/10/2012 07:50 AM, Minkyu Kang wrote:
> This patch fix following errors
>
> universal.c: In function 'init_pmic_lcd':
> universal.c:340: warning: implicit declaration of function 'get_pmic'
> universal.c:340: warning: initialization makes pointer from integer without a cast
> universal.c: In function 'lcd_power_on':
> universal.c:431: warning: initialization makes pointer from integer without a cast
> universal.c: At top level:
> universal.c:335: warning: 'init_pmic_lcd' defined but not used
>
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Donghwa Lee <dh09.lee@samsung.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> ---
>   board/samsung/universal_c210/universal.c |    8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/board/samsung/universal_c210/universal.c b/board/samsung/universal_c210/universal.c
> index 3d508be..4869798 100644
> --- a/board/samsung/universal_c210/universal.c
> +++ b/board/samsung/universal_c210/universal.c
> @@ -55,6 +55,8 @@ static int get_hwrev(void)
>   	return board_rev & 0xFF;
>   }
>
> +static void init_pmic_lcd(void);
> +
>   int power_init_board(void)
>   {
>   	int ret;
> @@ -63,6 +65,8 @@ int power_init_board(void)
>   	if (ret)
>   		return ret;
>
> +	init_pmic_lcd();
> +
>   	return 0;
>   }
>
> @@ -337,7 +341,7 @@ static void init_pmic_lcd(void)
>   	unsigned char val;
>   	int ret = 0;
>
> -	struct pmic *p = get_pmic();
> +	struct pmic *p = pmic_get("MAX8998_PMIC");
>
>   	if (pmic_probe(p))
>   		return;
> @@ -428,7 +432,7 @@ static void reset_lcd(void)
>
>   static void lcd_power_on(void)
>   {
> -	struct pmic *p = get_pmic();
> +	struct pmic *p = pmic_get("MAX8998_PMIC");
>
>   	if (pmic_probe(p))
>   		return;
>
Tested-by: Piotr Wilczek <p.wilczek@samsung.com>

  parent reply	other threads:[~2012-12-10 10:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-10  6:50 [U-Boot] universal_c210: fix compiler error and compiler warning Minkyu Kang
2012-12-10  9:06 ` Wolfgang Denk
2012-12-10  9:32   ` Lukasz Majewski
2012-12-10  9:59     ` Minkyu Kang
2012-12-10 10:44     ` Wolfgang Denk
2012-12-10 10:28 ` Piotr Wilczek [this message]
2012-12-11  4:01 ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C5B957.1080704@samsung.com \
    --to=p.wilczek@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox