* [U-Boot] [PATCH] woodburn: Set gpio value in gpio_direction_output()
@ 2012-12-11 16:19 Fabio Estevam
2012-12-11 16:38 ` Stefano Babic
2012-12-11 16:45 ` Stefano Babic
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2012-12-11 16:19 UTC (permalink / raw)
To: u-boot
Set the gpio value in gpio_direction_output() instead of an extra gpio_set_value
call.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/woodburn/woodburn.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/board/woodburn/woodburn.c b/board/woodburn/woodburn.c
index 66a0d35..d74f360 100644
--- a/board/woodburn/woodburn.c
+++ b/board/woodburn/woodburn.c
@@ -133,8 +133,7 @@ int woodburn_init(void)
mxc_request_iomux(MX35_PIN_SCKR, MUX_CONFIG_ALT5);
gpio_direction_output(4, 1);
mxc_request_iomux(MX35_PIN_HCKT, MUX_CONFIG_ALT5);
- gpio_direction_output(9, 0);
- gpio_set_value(9, 1);
+ gpio_direction_output(9, 1);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] woodburn: Set gpio value in gpio_direction_output()
2012-12-11 16:19 [U-Boot] [PATCH] woodburn: Set gpio value in gpio_direction_output() Fabio Estevam
@ 2012-12-11 16:38 ` Stefano Babic
2012-12-11 16:45 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2012-12-11 16:38 UTC (permalink / raw)
To: u-boot
On 11/12/2012 17:19, Fabio Estevam wrote:
> Set the gpio value in gpio_direction_output() instead of an extra gpio_set_value
> call.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> board/woodburn/woodburn.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/board/woodburn/woodburn.c b/board/woodburn/woodburn.c
> index 66a0d35..d74f360 100644
> --- a/board/woodburn/woodburn.c
> +++ b/board/woodburn/woodburn.c
> @@ -133,8 +133,7 @@ int woodburn_init(void)
> mxc_request_iomux(MX35_PIN_SCKR, MUX_CONFIG_ALT5);
> gpio_direction_output(4, 1);
> mxc_request_iomux(MX35_PIN_HCKT, MUX_CONFIG_ALT5);
> - gpio_direction_output(9, 0);
> - gpio_set_value(9, 1);
> + gpio_direction_output(9, 1);
>
> return 0;
> }
>
Thanks !
Acked-by: Stefano Babic <sbabic@denx.de>
Regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] woodburn: Set gpio value in gpio_direction_output()
2012-12-11 16:19 [U-Boot] [PATCH] woodburn: Set gpio value in gpio_direction_output() Fabio Estevam
2012-12-11 16:38 ` Stefano Babic
@ 2012-12-11 16:45 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2012-12-11 16:45 UTC (permalink / raw)
To: u-boot
On 11/12/2012 17:19, Fabio Estevam wrote:
> Set the gpio value in gpio_direction_output() instead of an extra gpio_set_value
> call.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> board/woodburn/woodburn.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/board/woodburn/woodburn.c b/board/woodburn/woodburn.c
> index 66a0d35..d74f360 100644
> --- a/board/woodburn/woodburn.c
> +++ b/board/woodburn/woodburn.c
> @@ -133,8 +133,7 @@ int woodburn_init(void)
> mxc_request_iomux(MX35_PIN_SCKR, MUX_CONFIG_ALT5);
> gpio_direction_output(4, 1);
> mxc_request_iomux(MX35_PIN_HCKT, MUX_CONFIG_ALT5);
> - gpio_direction_output(9, 0);
> - gpio_set_value(9, 1);
> + gpio_direction_output(9, 1);
>
> return 0;
> }
>
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-11 16:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-11 16:19 [U-Boot] [PATCH] woodburn: Set gpio value in gpio_direction_output() Fabio Estevam
2012-12-11 16:38 ` Stefano Babic
2012-12-11 16:45 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox