From mboxrd@z Thu Jan  1 00:00:00 1970
From: Armando Visconti <armando.visconti@st.com>
Date: Wed, 12 Dec 2012 12:10:06 +0100
Subject: [U-Boot] [PATCH resend] spi/arm-pl022: Add support for ARM
 PL022 spi controller
In-Reply-To: <50C85D3C.3050104@st.com>
References: <5a15a3f113b47952564abf488d65ae23f9bd6d79.1354776865.git.vipin.kumar@st.com>
	<50C859F5.6020907@denx.de> <50C85D3C.3050104@st.com>
Message-ID: <50C8660E.4060800@st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

>>> +
>>> +/* SSP registers mapping */
>>> +#define SSP_CR0		0x000
>>> +#define SSP_CR1		0x004
>>> +#define SSP_DR		0x008
>>> +#define SSP_SR		0x00C
>>> +#define SSP_CPSR	0x010
>>> +#define SSP_IMSC	0x014
>>> +#define SSP_RIS		0x018
>>> +#define SSP_MIS		0x01C
>>> +#define SSP_ICR		0x020
>>> +#define SSP_DMACR	0x024
>>> +#define SSP_ITCR	0x080
>>> +#define SSP_ITIP	0x084
>>> +#define SSP_ITOP	0x088
>>> +#define SSP_TDR		0x08C
>>
>> Please use C-structs instead to access the registers.
>>
>
> May be this patch is a ripped version from linux. That's why
> Thanks. I will do this in v2
>

Yes,
I took this part from the linux pl022 driver.

Never understood which way (C-struct or defines) is preferable
and why...

Rgds,
Arm