From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vipin Kumar <vipin.kumar@st.com>
Date: Wed, 12 Dec 2012 16:43:32 +0530
Subject: [U-Boot] [PATCH resend 2/2] net/macb: Add arch specific routine
 to get mdio control
In-Reply-To: <50C8658A.1060706@denx.de>
References: <21ad31fb0501d0cd56f978467ae31f153a22ec4b.1354777675.git.vipin.kumar@st.com>
	<8ff845e533e9d174c6fe70cc8a6be5ec753bd071.1354777675.git.vipin.kumar@st.com>
	<50C8658A.1060706@denx.de>
Message-ID: <50C866DC.8050206@st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 12/12/2012 4:37 PM, Stefan Roese wrote:
> On 12/06/2012 08:10 AM, Vipin Kumar wrote:
>> From: Shiraz Hashim<shiraz.hashim@st.com>
>>
>> SPEAr310 and SPEAr320 Ethernet interfaces share same MDIO lines to control their
>> respective phys. Currently their is a fixed configuration in which only a
>> particular MAC can use the MDIO lines.
>
> "there is" instead of "their is"
>

Thanks. I would change this in v2

>> Call an arch specific function to take control of specific mdio lines at
>> runtime.
>>
>> Signed-off-by: Shiraz Hashim<shiraz.hashim@st.com>
>> Signed-off-by: Vipin Kumar<vipin.kumar@st.com>
>> ---
>>   drivers/net/macb.c | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
>> index 8bacbda..45fbbd7 100644
>> --- a/drivers/net/macb.c
>> +++ b/drivers/net/macb.c
>> @@ -163,6 +163,13 @@ static u16 macb_mdio_read(struct macb_device *macb, u8 reg)
>>   	return MACB_BFEXT(DATA, frame);
>>   }
>>
>> +static void __def_arch_get_mdio_control(const char *name)
>> +{
>> +	return;
>> +}
>> +int arch_get_mdio_control(const char *name)
>> +	__attribute__((weak, alias("__def_arch_get_mdio_control")));
>
> __weak from linux/compiler.h please
>

in v2

> Otherwise:
>
> Acked-by: Stefan Roese<sr@denx.de>
>
> Thanks,
> Stefan
>
>

Vipin