From: Vipin Kumar <vipin.kumar@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] imls: Add support to list images in NAND device
Date: Thu, 13 Dec 2012 11:21:02 +0530 [thread overview]
Message-ID: <50C96CC6.3080707@st.com> (raw)
In-Reply-To: <20121212202412.16380200FD0@gemini.denx.de>
On 12/13/2012 1:54 AM, Wolfgang Denk wrote:
> Dear Vipin Kumar,
>
> In message<dba14c4ffef38a108f75342968bcd9ce2b75c4c7.1355303894.git.vipin.kumar@st.com> you wrote:
>> imls does not list the images in NAND devices. This patch implements this
>> support for legacy type images.
> ...
>> -static int do_imls(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>> +static void do_imls_flash(void)
>
> Why is this void? Should we not return error codes? Or at least be
> able to?
>
Yes, I agree. I would change this
>> +static void do_imls_nand(void)
>
> Ditto.
>
>
> Best regards,
>
> Wolfgang Denk
>
next prev parent reply other threads:[~2012-12-13 5:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 9:20 [U-Boot] [PATCH v2] imls: Add support to list images in NAND device Vipin Kumar
2012-12-12 20:24 ` Wolfgang Denk
2012-12-13 5:51 ` Vipin Kumar [this message]
2012-12-12 23:00 ` Scott Wood
2012-12-13 6:10 ` Vipin Kumar
2012-12-13 21:52 ` Scott Wood
2012-12-14 9:23 ` Vipin Kumar
2012-12-14 18:59 ` Scott Wood
2012-12-17 8:18 ` Vipin Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C96CC6.3080707@st.com \
--to=vipin.kumar@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox