From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 13 Dec 2012 08:11:55 -0500 Subject: [U-Boot] [PATCH] ns16550: allow UART address to be set dynamically In-Reply-To: <20121213102711.6585C20120D@gemini.denx.de> References: <1355354590-10023-1-git-send-email-swarren@wwwdotorg.org> <20121213102711.6585C20120D@gemini.denx.de> Message-ID: <50C9D41B.7010800@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/13/12 05:27, Wolfgang Denk wrote: > Dear Stephen Warren, > > In message > <1355354590-10023-1-git-send-email-swarren@wwwdotorg.org> you > wrote: >> From: Stephen Warren >> >> A single U-Boot binary may support multiple very similar boards. >> These boards may use different UARTs for the main debug console. >> Hence, it is impossible to #define CONFIG_SYS_NS16550_COM1 to >> some static UART address, since the true value may only be >> determined at run-time, after identifying the actual hardware. >> Provide an API for boards to call to set the actual address of >> the UART, e.g. from spl_board_init() or board_early_init_f(). >> >> Signed-off-by: Stephen Warren > > As is, this is just adding dead code. > > Where would the device addresses come from - out of the device > tree? Board specific knowledge. I'd be tempted to add UART3 (iirc) into the am335x_evm default build so that we can support the Industrial DevKit variant out of the box, rather than needing one of the other _uartN builds. We can tell which board we're on at run-time already. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIcBAEBAgAGBQJQydQbAAoJENk4IS6UOR1WLpsP/3TsidcGHLMQoqyktG/qtzFr LmIT7wfNomLsl7xmTrO0B4GwvpsH6OucW90z6HrL0qvH3IhZ2FohUcyWwWNNo2KZ 1gEFSMPbwZt3htrFE/fhHT8n+Fo/eq2hY32WmxnWV8XS46+FL348FHNxEeIiQN1p 1MwxmJmEGBqAtBdC7t2JIoHsQqd+txDs6R5xpm8f2S2zenJFkbp45FwDeQrn4Bu/ XVagwL4R/L21bPt/I90RdkRe5lt7ukQwoG1+HgaEjoCdiCol9p6bjBwWll+NXb9/ ouk+7rYEncjxn+/W9XB7ojeBwOMxQbreg4JJFikn41g5XOkLIe+l0n2/j1jWVSOO u3ORXxOr1icMRY9BgUkLuKlhtONQX5IPz8t5F4N8tyhsGFSxs6kuX2NKo+Oy25B5 cidh43exx8VkHqInsq7ZFlll/Xdk7PD16iY7qoZh8BE6KzdbchBeZX2bCn3NiOIS RtfVXrng58PaetHyzjsfcu1HDaaGez8vztabVUF4PECQmnV7hz2Vw25HqoK9un/L Snl9uPNBELKA7DesPRMx0LaGwDkx4UBecvX2nWm+krkihvbdalmnawNbIWv9WNSt OG3w+r/Ka68t2vFVTbIBVK7IVeDe/dISLpQ7R/MiVIzJDnD9EFJUQpaKxWp54PKF ZV4bb59FxRxBpkO5eA1L =QfiQ -----END PGP SIGNATURE-----