From: Vipin Kumar <vipin.kumar@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] usbh/ehci: Increase timeout for enumeration
Date: Fri, 14 Dec 2012 14:28:18 +0530 [thread overview]
Message-ID: <50CAEA2A.90705@st.com> (raw)
In-Reply-To: <201212131411.18016.marex@denx.de>
On 12/13/2012 6:41 PM, Marek Vasut wrote:
> Dear Vipin Kumar,
>
>> The current logic reads the port status just once after usb_hub_power_on
>> and expects the portstatus and portchange to report the connection status
>> immediately and correctly.
>>
>> Few pen drives are not able to report both of them immediately ie. those
>> pens report the connection change but not the connected state after the
>> first read. This opportunity once lost is gone for ever because the
>> u-boot, unlike linux or any other OS, works in polling mode.
>>
>> This patch modifies the logic to read the port status continuously until
>> the portstatus and portchange both report a connection change as well as a
>> connected state or no connection change and no connection. This logic is
>> placed in a timeout of 10 sec. At the end of it, the pen drive would have
>> either reported a ONE or a ZERO in bit 1 of portstatus as well as
>> portchange.
>>
>> It enhances the set of pen drives which can eventually be detected by
>> u-boot
>>
>> Note: This 10 second timeout is based purely on several experiments done
>> with the broken pen drives
>>
>> Signed-off-by: Vipin Kumar<vipin.kumar@st.com>
>> Acked-by: Igor Grinberg<grinberg@compulab.co.il>
>
> Applied, tested. Thanks
>
Thanks Marek
> Best regards,
> Marek Vasut
>
prev parent reply other threads:[~2012-12-14 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 10:55 [U-Boot] [PATCH v3] usbh/ehci: Increase timeout for enumeration Vipin Kumar
2012-12-13 13:11 ` Marek Vasut
2012-12-14 8:58 ` Vipin Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CAEA2A.90705@st.com \
--to=vipin.kumar@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox