From mboxrd@z Thu Jan  1 00:00:00 1970
From: Minkyu Kang <mk7.kang@samsung.com>
Date: Sat, 15 Dec 2012 14:25:19 +0900
Subject: [U-Boot] [PATCH RESEND 2/4] video: Fix compilation dependency
 of exynos_dp and exynos_mipi on exynos_fb
In-Reply-To: <1355398167-24845-3-git-send-email-ajaykumar.rs@samsung.com>
References: <1355398167-24845-1-git-send-email-ajaykumar.rs@samsung.com>
	<1355398167-24845-3-git-send-email-ajaykumar.rs@samsung.com>
Message-ID: <50CC09BF.6010203@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Ajay,

On 13/12/12 20:29, Ajay Kumar wrote:
> When only DP is used, we need not enable CONFIG_EXYNOS_MIPI_DSIM.
> Similarly, when only MIPI is used, we need not enable CONFIG_EXYNOS_DP.
> But the current structuring of code forces us to enable both
> CONFIG_EXYNOS_MIPI_DSIM and CONFIG_EXYNOS_DP.
> This patch adds conditional compilation check to remove the dependency.
> 
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> Acked-by: Simon Glass <sjg@chromium.org>
> ---
>  drivers/video/exynos_fb.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c
> index d9a3f9a..39d3b74 100644
> --- a/drivers/video/exynos_fb.c
> +++ b/drivers/video/exynos_fb.c
> @@ -103,8 +103,10 @@ static void lcd_panel_on(vidinfo_t *vid)
>  
>  	udelay(vid->power_on_delay);
>  
> +#ifdef CONFIG_EXYNOS_DP
>  	if (vid->dp_enabled)
>  		exynos_init_dp();
> +#endif

Unnecessary.
please see arch/arm/include/asm/arch-exynos/dp_info.h

#ifdef CONFIG_EXYNOS_DP
unsigned int exynos_init_dp(void);
#else
unsigned int exynos_init_dp(void)
{
	return 0;
}
#endif

>  
>  	if (vid->reset_lcd) {
>  		vid->reset_lcd();
> @@ -120,8 +122,10 @@ static void lcd_panel_on(vidinfo_t *vid)
>  	if (vid->enable_ldo)
>  		vid->enable_ldo(1);
>  
> +#ifdef CONFIG_EXYNOS_MIPI_DSIM
>  	if (vid->mipi_enabled)
>  		exynos_mipi_dsi_init();
> +#endif

This should be modified like exynos_init_dp?

Donghwa, how you think?

>  }
>  
>  void lcd_ctrl_init(void *lcdbase)
> 

Thanks.
Minkyu Kang.