From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vipin Kumar <vipin.kumar@st.com>
Date: Mon, 17 Dec 2012 13:45:00 +0530
Subject: [U-Boot] [PATCH resend 2/2] arm/boards: Define a new config
	option CONFIG_BOOT_PARAMS_P
In-Reply-To: <20121207144733.0FDFE201621@gemini.denx.de>
References: <0914ca07f3fa7549188e349e7a0a32c3d6521321.1354786138.git.vipin.kumar@st.com>
	<ee5f783dffac1a94acdd7bb7f8f20cc6c4af7019.1354786138.git.vipin.kumar@st.com>
	<50C068F4.3000107@denx.de> <50C06BD5.7010507@st.com>
	<50C080CF.10604@denx.de> <50C1B9A6.1020106@st.com>
	<20121207144733.0FDFE201621@gemini.denx.de>
Message-ID: <50CED484.1060501@st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 12/7/2012 8:17 PM, Wolfgang Denk wrote:
> Dear Vipin Kumar,
>
> In message<50C1B9A6.1020106@st.com>  you wrote:
>>
>> Can you please suggest what is the best way here. Wolfgang, Albert ?
>
> I don't like this patch at all.   It introduces yet more
> architecture specific stuff to lib/board.c, while we actually should
> be working on coming up with a common version for all architectures.
>
> If you want to simplify code, then please not by making it worse in
> other places.
>

I agree, but this code adds an option to pass boot params pointer to 
board descriptor.
Just two lines above the intended change, there is a mach_type 
initialization based on the definition of CONFIG_MACH_TYPE. Moreover, 
the lib/board.c exists in arch/arm as of today which means that it can 
contain all the stuff common for arm boards

If I am right, the patch should also be OK

Vipin

> Best regards,
>
> Wolfgang Denk
>