[U-Boot] [PATCH] boards/T4240qds:Fix IFC AMASK init as per FPGA register space

public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed

* [U-Boot] [PATCH] boards/T4240qds:Fix IFC AMASK init as per FPGA register space
@ 2012-12-18 10:16 Prabhakar Kushwaha
  2012-12-18 15:42 ` [U-Boot] [u-boot-release] " Timur Tabi
  0 siblings, 1 reply; 3+ messages in thread
From: Prabhakar Kushwaha @ 2012-12-18 10:16 UTC (permalink / raw)
  To: u-boot

T4240QDS's QIXIS FPGA has 4k register space size and IFC controller's
Address Mask Registers is initialised 64K size.

So Fix the Address Mask Register initilisation as 4K

Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
---
 include/configs/t4qds.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/t4qds.h b/include/configs/t4qds.h
index d58c24c..c909ed8 100644
--- a/include/configs/t4qds.h
+++ b/include/configs/t4qds.h
@@ -259,7 +259,7 @@ unsigned long get_board_ddr_clk(void);
 				| CSPR_PORT_SIZE_8 \
 				| CSPR_MSEL_GPCM \
 				| CSPR_V)
-#define CONFIG_SYS_AMASK3	IFC_AMASK(64*1024)
+#define CONFIG_SYS_AMASK3	IFC_AMASK(4*1024)
 #define CONFIG_SYS_CSOR3	0x0
 /* QIXIS Timing parameters for IFC CS3 */
 #define CONFIG_SYS_CS3_FTIM0		(FTIM0_GPCM_TACSE(0x0e) | \
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [u-boot-release] [PATCH] boards/T4240qds:Fix IFC AMASK init as per FPGA register space
  2012-12-18 10:16 [U-Boot] [PATCH] boards/T4240qds:Fix IFC AMASK init as per FPGA register space Prabhakar Kushwaha
@ 2012-12-18 15:42 ` Timur Tabi
  2012-12-19  2:59   ` Prabhakar Kushwaha
  0 siblings, 1 reply; 3+ messages in thread
From: Timur Tabi @ 2012-12-18 15:42 UTC (permalink / raw)
  To: u-boot

Prabhakar Kushwaha wrote:
> +#define CONFIG_SYS_AMASK3	IFC_AMASK(4*1024)

	IFC_AMASK(4 * 1024)

Spaces around binary operators, please.

-- 
Timur Tabi
Linux kernel developer at Freescale

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [u-boot-release] [PATCH] boards/T4240qds:Fix IFC AMASK init as per FPGA register space
  2012-12-18 15:42 ` [U-Boot] [u-boot-release] " Timur Tabi
@ 2012-12-19  2:59   ` Prabhakar Kushwaha
  0 siblings, 0 replies; 3+ messages in thread
From: Prabhakar Kushwaha @ 2012-12-19  2:59 UTC (permalink / raw)
  To: u-boot

On 12/18/2012 09:12 PM, Timur Tabi wrote:
> Prabhakar Kushwaha wrote:
>> +#define CONFIG_SYS_AMASK3	IFC_AMASK(4*1024)
> 	IFC_AMASK(4 * 1024)
>
> Spaces around binary operators, please.
>

Thanks Timur for reviewing it.

I will fix this in next patch version.

Regards,
Prabhakar

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-12-19  2:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-18 10:16 [U-Boot] [PATCH] boards/T4240qds:Fix IFC AMASK init as per FPGA register space Prabhakar Kushwaha
2012-12-18 15:42 ` [U-Boot] [u-boot-release] " Timur Tabi
2012-12-19  2:59   ` Prabhakar Kushwaha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox