From: Nikita Kiryanov <nikita@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/7] omap_hsmmc: implement driver check for card detection
Date: Wed, 19 Dec 2012 08:58:44 +0200 [thread overview]
Message-ID: <50D165A4.1050409@compulab.co.il> (raw)
In-Reply-To: <20121218235226.GC14589@bill-the-cat>
On 12/19/2012 01:52 AM, Tom Rini wrote:
> On Mon, Dec 03, 2012 at 02:19:44PM +0200, Nikita Kiryanov wrote:
>
>> Implement driver check for card detection.
>>
>> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>
>> - ret = omap_mmc_init(0, 0, 0);
>> + ret = omap_mmc_init(0, 0, 0, -1);
>
> Everyone passes -1 here, including the follow-up patch for cm_t35. Why
> do we need the change?
>
This change is useful because on OMAP it's a fair assumption
that card detect (and write protect) signal will be ascertained via
a GPIO, though it is not a certainty.
Everybody who is not cm_t35 get a -1 because I did not try to
figure out if they really do use GPIOs for card detect.
cm_t35 gets a -1 because it does not use OMAP GPIOs for card detect,
but relies on those of the PMIC instead.
--
Regards,
Nikita.
next prev parent reply other threads:[~2012-12-19 6:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 12:19 [U-Boot] [PATCH 0/7] omap mmc: implement card detect and write protection Nikita Kiryanov
2012-12-03 12:19 ` [U-Boot] [PATCH 1/7] omap: consolidate common mmc definitions Nikita Kiryanov
2012-12-03 12:19 ` [U-Boot] [PATCH 2/7] omap_hsmmc: fix out of bounds array access Nikita Kiryanov
2012-12-03 12:19 ` [U-Boot] [PATCH 3/7] omap_hsmmc: introduce omap_hsmmc_data struct Nikita Kiryanov
2012-12-03 12:19 ` [U-Boot] [PATCH 4/7] omap_hsmmc: implement driver check for card detection Nikita Kiryanov
2012-12-18 23:52 ` Tom Rini
2012-12-19 6:58 ` Nikita Kiryanov [this message]
2012-12-03 12:19 ` [U-Boot] [PATCH 5/7] cm-t35: implement board specific card detect check Nikita Kiryanov
2012-12-03 12:19 ` [U-Boot] [PATCH 6/7] mmc: add support for write protection Nikita Kiryanov
2012-12-03 12:19 ` [U-Boot] [PATCH 7/7] omap_hsmmc: add driver check " Nikita Kiryanov
2013-02-15 21:22 ` Tom Rini
2012-12-18 7:58 ` [U-Boot] [PATCH 0/7] omap mmc: implement card detect and " Nikita Kiryanov
2012-12-30 6:13 ` Nikita Kiryanov
2013-01-07 14:43 ` Tom Rini
2013-01-31 7:44 ` Igor Grinberg
2013-02-13 7:27 ` Nikita Kiryanov
2013-02-15 21:24 ` Tom Rini
2013-03-05 7:53 ` Nikita Kiryanov
2013-03-09 7:11 ` Igor Grinberg
2013-03-09 12:18 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D165A4.1050409@compulab.co.il \
--to=nikita@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox