From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Kiryanov Date: Wed, 19 Dec 2012 08:58:44 +0200 Subject: [U-Boot] [PATCH 4/7] omap_hsmmc: implement driver check for card detection In-Reply-To: <20121218235226.GC14589@bill-the-cat> References: <1354537187-26744-1-git-send-email-nikita@compulab.co.il> <1354537187-26744-5-git-send-email-nikita@compulab.co.il> <20121218235226.GC14589@bill-the-cat> Message-ID: <50D165A4.1050409@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/19/2012 01:52 AM, Tom Rini wrote: > On Mon, Dec 03, 2012 at 02:19:44PM +0200, Nikita Kiryanov wrote: > >> Implement driver check for card detection. >> >> Signed-off-by: Nikita Kiryanov >> Signed-off-by: Igor Grinberg > >> - ret = omap_mmc_init(0, 0, 0); >> + ret = omap_mmc_init(0, 0, 0, -1); > > Everyone passes -1 here, including the follow-up patch for cm_t35. Why > do we need the change? > This change is useful because on OMAP it's a fair assumption that card detect (and write protect) signal will be ascertained via a GPIO, though it is not a certainty. Everybody who is not cm_t35 get a -1 because I did not try to figure out if they really do use GPIOs for card detect. cm_t35 gets a -1 because it does not use OMAP GPIOs for card detect, but relies on those of the PMIC instead. -- Regards, Nikita.