From mboxrd@z Thu Jan 1 00:00:00 1970 From: Donghwa Lee Date: Fri, 21 Dec 2012 10:47:18 +0900 Subject: [U-Boot] [PATCH V3 2/4] EXYNOS: Add dummy definition to fix compilation dependency on CONFIG_EXYNOS_MIPI_DSIM In-Reply-To: <1356006906-31510-3-git-send-email-ajaykumar.rs@samsung.com> References: <1356006906-31510-1-git-send-email-ajaykumar.rs@samsung.com> <1356006906-31510-3-git-send-email-ajaykumar.rs@samsung.com> Message-ID: <50D3BFA6.5010208@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 2012? 12? 20? 21:35, Ajay Kumar wrote: > When only DP is used, we need not enable CONFIG_EXYNOS_MIPI_DSIM. > But if we do not select CONFIG_EXYNOS_MIPI_DSIM, exynos_fb.c throws > error saying exynos_mipi_dsi_init() not defined. So, we add > dummy definition for exynos_mipi_dsi_init when CONFIG_EXYNOS_MIPI_DSIM > is not defined. > > Signed-off-by: Ajay Kumar > --- > arch/arm/include/asm/arch-exynos/mipi_dsim.h | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/include/asm/arch-exynos/mipi_dsim.h b/arch/arm/include/asm/arch-exynos/mipi_dsim.h > index 9a7cbeb..b73263d 100644 > --- a/arch/arm/include/asm/arch-exynos/mipi_dsim.h > +++ b/arch/arm/include/asm/arch-exynos/mipi_dsim.h > @@ -358,7 +358,14 @@ struct mipi_dsim_lcd_driver { > void (*mipi_display_on)(struct mipi_dsim_device *dsim_dev); > }; > > +#ifdef CONFIG_EXYNOS_MIPI_DSIM > int exynos_mipi_dsi_init(void); > +#else > +int exynos_mipi_dsi_init(void) > +{ > + return 0; > +} > +#endif > > /* > * register mipi_dsim_lcd_driver object defined by lcd panel driver It looks good to me. Acked-by: Donghwa Lee Thank you, Donghwa Lee