From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/9] EXYNOS5: FDT: Add DWMMC device node data
Date: Fri, 21 Dec 2012 18:19:34 +0900 [thread overview]
Message-ID: <50D429A6.1080105@samsung.com> (raw)
In-Reply-To: <CAPnjgZ3CMmgSSZduxfKBjsLODr_soEe7YDWx+bMMBO964AhvUA@mail.gmail.com>
On 12/20/2012 10:55 AM, Simon Glass wrote:
> Hi Amar,
>
> On Mon, Dec 17, 2012 at 3:19 AM, Amar <amarendra.xt@samsung.com> wrote:
>> Add DWMMC device node data for exynos5
>>
>> Signed-off-by: Amar <amarendra.xt@samsung.com>
>> ---
>> arch/arm/dts/exynos5250.dtsi | 32 +++++++++++++++++++++++++++++
>> board/samsung/dts/exynos5250-smdk5250.dts | 24 +++++++++++++++++++++
>
> Do you also have a binding file for this please?
>
>> 2 files changed, 56 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/dts/exynos5250.dtsi b/arch/arm/dts/exynos5250.dtsi
>> index 1008797..b701ae5 100644
>> --- a/arch/arm/dts/exynos5250.dtsi
>> +++ b/arch/arm/dts/exynos5250.dtsi
>> @@ -138,4 +138,36 @@
>> reg = <0x131b0000 0x30>;
>> interrupts = <0 130 0>;
>> };
>> +
>> + dwmmc at 12200000 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "samsung,exynos5250-dwmmc";
>> + reg = <0x12200000 0x1000>;
>> + interrupts = <0 75 0>;
>> + };
>> +
>> + dwmmc at 12210000 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "samsung,exynos5250-dwmmc";
>> + reg = <0x12210000 0x1000>;
>> + interrupts = <0 76 0>;
>> + };
>> +
>> + dwmmc at 12220000 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "samsung,exynos5250-dwmmc";
>> + reg = <0x12220000 0x1000>;
>> + interrupts = <0 77 0>;
>> + };
>> +
>> + dwmmc at 12230000 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "samsung,exynos5250-dwmmc";
>> + reg = <0x12230000 0x1000>;
>> + interrupts = <0 78 0>;
>> + };
>> };
>> diff --git a/board/samsung/dts/exynos5250-smdk5250.dts b/board/samsung/dts/exynos5250-smdk5250.dts
>> index a8e62da..b1b8d71 100644
>> --- a/board/samsung/dts/exynos5250-smdk5250.dts
>> +++ b/board/samsung/dts/exynos5250-smdk5250.dts
>> @@ -30,6 +30,10 @@
>> spi2 = "/spi at 12d40000";
>> spi3 = "/spi at 131a0000";
>> spi4 = "/spi at 131b0000";
>> + dwmmc0 = "/dwmmc at 12200000";
>> + dwmmc1 = "/dwmmc at 12210000";
>> + dwmmc2 = "/dwmmc at 12220000";
>> + dwmmc3 = "/dwmmc at 12230000";
>> };
>>
>> sromc at 12250000 {
>> @@ -59,4 +63,24 @@
>> compatible = "wolfson,wm8994-codec";
>> };
>> };
>> +
>> + dwmmc at 12200000 {
>> + index = <0>;
>
> Do you really need the index? You have the numbering from the aliaes I think.
>
>> + bus-width = <8>;
>> + timing = <1 3 3>;
>
> Might need a "samsung," prefix on these?
I think better that use the "exynos" instead of "samsung".
how about?
>
>> + };
>> +
>> + dwmmc at 12210000 {
>> + status = "disabled";
>> + };
>> +
>> + dwmmc at 12220000 {
>> + index = <2>;
>> + bus-width = <4>;
>> + timing = <1 2 3>;
>> + };
>> +
>> + dwmmc at 12230000 {
>> + status = "disabled";
>> + };
>> };
>> --
>> 1.7.0.4
>>
>
> Regards,
> Simon
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
next prev parent reply other threads:[~2012-12-21 9:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 11:19 [U-Boot] [PATCH 0/9] EXYNOS5: Enable dwmmc Amar
2012-12-17 11:19 ` [U-Boot] [PATCH 1/9] FDT: Add compatible string for DWMMC Amar
2012-12-20 1:53 ` Simon Glass
2012-12-17 11:19 ` [U-Boot] [PATCH 2/9] EXYNOS5: FDT: Add DWMMC device node data Amar
2012-12-20 1:55 ` Simon Glass
2012-12-21 9:19 ` Jaehoon Chung [this message]
2012-12-21 21:24 ` Simon Glass
2012-12-24 6:54 ` Amarendra Reddy
2012-12-17 11:19 ` [U-Boot] [PATCH 4/9] EXYNOS5: DWMMC: Added dt support for DWMMC Amar
2012-12-20 2:23 ` Simon Glass
2012-12-21 5:16 ` Amarendra Reddy
2012-12-21 9:18 ` Jaehoon Chung
2012-12-24 7:20 ` Amarendra Reddy
2012-12-17 11:19 ` [U-Boot] [PATCH 5/9] EXYNOS5: DWMMC: API to set mmc clock divisor Amar
2012-12-20 2:24 ` Simon Glass
2012-12-21 5:18 ` Amarendra Reddy
2012-12-17 11:19 ` [U-Boot] [PATCH 6/9] SMDK5250: Enable DWMMC Amar
2012-12-20 2:29 ` Simon Glass
2012-12-21 5:27 ` Amarendra Reddy
2012-12-17 11:19 ` [U-Boot] [PATCH 7/9] MMC: APIs to support creation of boot partition Amar
2012-12-20 2:31 ` Simon Glass
2012-12-20 13:57 ` Amarendra Reddy
2012-12-17 11:19 ` [U-Boot] [PATCH 8/9] SMDK5250: Enable eMMC booting Amar
2012-12-20 2:35 ` Simon Glass
2012-12-20 13:53 ` Amarendra Reddy
2012-12-26 19:59 ` Simon Glass
2012-12-27 3:55 ` Amarendra Reddy
2012-12-17 11:19 ` [U-Boot] [PATCH 9/9] COMMON: MMC: Command to support " Amar
2012-12-20 2:40 ` Simon Glass
2012-12-20 13:45 ` Amarendra Reddy
-- strict thread matches above, loose matches on Subject: below --
2012-12-28 15:52 [U-Boot] [PATCH V2 0/9] EXYNOS5: Enable dwmmc Amar
2012-12-28 15:52 ` [U-Boot] [PATCH 2/9] EXYNOS5: FDT: Add DWMMC device node data Amar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D429A6.1080105@samsung.com \
--to=jh80.chung@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox