From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jaehoon Chung <jh80.chung@samsung.com>
Date: Fri, 21 Dec 2012 18:19:34 +0900
Subject: [U-Boot] [PATCH 2/9] EXYNOS5: FDT: Add DWMMC device node data
In-Reply-To: <CAPnjgZ3CMmgSSZduxfKBjsLODr_soEe7YDWx+bMMBO964AhvUA@mail.gmail.com>
References: <1355743176-12305-1-git-send-email-amarendra.xt@samsung.com>
	<1355743176-12305-3-git-send-email-amarendra.xt@samsung.com>
	<CAPnjgZ3CMmgSSZduxfKBjsLODr_soEe7YDWx+bMMBO964AhvUA@mail.gmail.com>
Message-ID: <50D429A6.1080105@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 12/20/2012 10:55 AM, Simon Glass wrote:
> Hi Amar,
> 
> On Mon, Dec 17, 2012 at 3:19 AM, Amar <amarendra.xt@samsung.com> wrote:
>> Add DWMMC device node data for exynos5
>>
>> Signed-off-by: Amar <amarendra.xt@samsung.com>
>> ---
>>  arch/arm/dts/exynos5250.dtsi              |   32 +++++++++++++++++++++++++++++
>>  board/samsung/dts/exynos5250-smdk5250.dts |   24 +++++++++++++++++++++
> 
> Do you also have a binding file for this please?
> 
>>  2 files changed, 56 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/dts/exynos5250.dtsi b/arch/arm/dts/exynos5250.dtsi
>> index 1008797..b701ae5 100644
>> --- a/arch/arm/dts/exynos5250.dtsi
>> +++ b/arch/arm/dts/exynos5250.dtsi
>> @@ -138,4 +138,36 @@
>>                 reg = <0x131b0000 0x30>;
>>                 interrupts = <0 130 0>;
>>         };
>> +
>> +       dwmmc at 12200000 {
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +               compatible = "samsung,exynos5250-dwmmc";
>> +               reg = <0x12200000 0x1000>;
>> +               interrupts = <0 75 0>;
>> +       };
>> +
>> +       dwmmc at 12210000 {
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +               compatible = "samsung,exynos5250-dwmmc";
>> +               reg = <0x12210000 0x1000>;
>> +               interrupts = <0 76 0>;
>> +       };
>> +
>> +       dwmmc at 12220000 {
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +               compatible = "samsung,exynos5250-dwmmc";
>> +               reg = <0x12220000 0x1000>;
>> +               interrupts = <0 77 0>;
>> +       };
>> +
>> +       dwmmc at 12230000 {
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +               compatible = "samsung,exynos5250-dwmmc";
>> +               reg = <0x12230000 0x1000>;
>> +               interrupts = <0 78 0>;
>> +       };
>>  };
>> diff --git a/board/samsung/dts/exynos5250-smdk5250.dts b/board/samsung/dts/exynos5250-smdk5250.dts
>> index a8e62da..b1b8d71 100644
>> --- a/board/samsung/dts/exynos5250-smdk5250.dts
>> +++ b/board/samsung/dts/exynos5250-smdk5250.dts
>> @@ -30,6 +30,10 @@
>>                 spi2 = "/spi at 12d40000";
>>                 spi3 = "/spi at 131a0000";
>>                 spi4 = "/spi at 131b0000";
>> +               dwmmc0 = "/dwmmc at 12200000";
>> +               dwmmc1 = "/dwmmc at 12210000";
>> +               dwmmc2 = "/dwmmc at 12220000";
>> +               dwmmc3 = "/dwmmc at 12230000";
>>         };
>>
>>         sromc at 12250000 {
>> @@ -59,4 +63,24 @@
>>                         compatible = "wolfson,wm8994-codec";
>>                 };
>>         };
>> +
>> +       dwmmc at 12200000 {
>> +               index = <0>;
> 
> Do you really need the index? You have the numbering from the aliaes I think.
> 
>> +               bus-width = <8>;
>> +               timing = <1 3 3>;
> 
> Might need a "samsung," prefix on these?
I think better that use the "exynos" instead of "samsung".
how about?
> 
>> +       };
>> +
>> +       dwmmc at 12210000 {
>> +               status = "disabled";
>> +       };
>> +
>> +       dwmmc at 12220000 {
>> +               index = <2>;
>> +               bus-width = <4>;
>> +               timing = <1 2 3>;
>> +       };
>> +
>> +       dwmmc at 12230000 {
>> +               status = "disabled";
>> +       };
>>  };
>> --
>> 1.7.0.4
>>
> 
> Regards,
> Simon
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>